-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract npm package tars into virtual store as action using tar toolchain from bazel-lib #1538
Conversation
3d9cf8d
to
9b17a2c
Compare
Can tar within |
It could but I'd rather change one thing at a time and do that in a follow-up. |
Yeah 👍 I just want to make sure it's considered because the |
9b17a2c
to
3a2ea52
Compare
3a2ea52
to
5edc084
Compare
5edc084
to
33d2a26
Compare
33d2a26
to
f4368fe
Compare
2855f93
to
1afd514
Compare
… toolchain from bazel-lib
1afd514
to
e3cfbf1
Compare
Should mostly fix #1412. I say mostly since this PR only applies for npm package with no lifecycle hooks and no patches. This is the majority of packages. This PR changes these so they will no longer use a CopyDirectory action with a source directory input to copy into the virtual store. Instead they will use a tar toolchain to extract the package
.tgz
directly into the virtual store.Packages with lifecycle hooks and patches will be handled in follow-up PRs. For lifecycle hooks, the lifecycle hook binary will need to run
tar --extract
itself. This should be fairly straight forward. For packages with patches, we'll likely need apatch
toolchain in bazel-lib so we have a hermeticpatch
we can call aftertar --extract
in some "extract and patch" action in bothnpm_package_store
and the lifecycle hook binary.Type of change
Test plan