feat: add package_visibility attribute to npm_translate_lock and npm_import #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
package_visibility
branch
11 times, most recently
from
01bdf61 to
a06bd7c
Compare
gregmagolan
changed the title
jbedard
reviewed
Oct 2, 2023
jbedard
reviewed
Oct 2, 2023
jbedard
reviewed
Oct 2, 2023
gregmagolan
force-pushed
the
package_visibility
branch
4 times, most recently
from
d95f55e to
5ca99d9
Compare
jbedard
reviewed
Oct 3, 2023
gregmagolan
force-pushed
the
package_visibility
branch
from
5ca99d9 to
2821f65
Compare
jbedard
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request from a consulting client.
Since link targets are generated by
npm_translate_lockandnpm_importrepository rules, customizable visibility for link targets must be annpm_translate_lockandnpm_importattributes. There is no way to set a visibility on annpm_packagetarget that could be propagated to the visibility of a link target that uses thatnpm_packagetarget via the virtual store link.Type of change
Test plan