Commit 06cea96
committed
fix: do not serialize Label() via "".join() when tar command fails (#2593)
While debugging an error in
#2592 it was failing to
output an error message instead saying:
```
expected string for sequence element 0, got '@@aspect_bazel_lib~~toolchains~bsd_tar_darwin_arm64//:tar' of type Label
```
This change makes it output the args in a format such as:
```
Failed to extract package tarball. '[Label("@@aspect_bazel_lib~~toolchains~bsd_tar_darwin_arm64//:tar"), "-xf", "package.tgz", "--strip-components", "1", "-C", "package", "--no-same-owner", "--no-same-permissions"]' exited with 1:
```
which might have the ugly `[...]` braces but at least it's not failing
to output the error message.
### Changes are visible to end-users: no
### Test plan
- Covered by existing test cases
- Manual testing1 parent e3d2256 commit 06cea96
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
552 | 552 | | |
553 | 553 | | |
554 | 554 | | |
555 | | - | |
| 555 | + | |
556 | 556 | | |
557 | 557 | | |
558 | 558 | | |
| |||
0 commit comments