[0.68] MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early (microsoft#9609)

JunielKatarn · asklar · asklar · commit 35d22a486bb7 · 2022-03-29T13:44:05.000-07:00
* MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early (microsoft#9562) * MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early * Change files * Change files Co-authored-by: Alexander Sklar <asklar@microsoft.com>
diff --git a/change/react-native-windows-8c4bdb9b-4524-4bef-8b96-75ec3f73f6f9.json b/change/react-native-windows-8c4bdb9b-4524-4bef-8b96-75ec3f73f6f9.json
@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "MustBeNoExceptVoidFunctor should depend on the template type parameter to avoid being evaluated too early (#9562)",
+  "packageName": "react-native-windows",
+  "email": "julio.rocha@microsoft.com",
+  "dependentChangeType": "patch"
+}
diff --git a/vnext/Mso/dispatchQueue/dispatchQueue.h b/vnext/Mso/dispatchQueue/dispatchQueue.h
@@ -723,9 +723,14 @@ inline DispatchTaskImpl<TInvoke, TOnCancel>::~DispatchTaskImpl() noexcept {
   }
 }
 
+namespace details {
+template <typename>
+constexpr bool always_false = false;
+}
+
 template <typename T>
 inline void MustBeNoExceptVoidFunctor() {
-  static_assert(false, __FUNCTION__ ": not a noexcept callable functor returning void");
+  static_assert(details::always_false<T>, __FUNCTION__ ": not a noexcept callable functor returning void");
 }
 
 template <typename TInvoke, typename TOnCancel>

Original file line number	Diff line number	Diff line change
`@@ -723,9 +723,14 @@ inline DispatchTaskImpl<TInvoke, TOnCancel>::~DispatchTaskImpl() noexcept {`
`723`	`723`	`}`
`724`	`724`	`}`
`725`	`725`
	`726`	`+namespace details {`
	`727`	`+template <typename>`
	`728`	`+constexpr bool always_false = false;`
	`729`	`+}`
	`730`	`+`
`726`	`731`	`template <typename T>`
`727`	`732`	`inline void MustBeNoExceptVoidFunctor() {`
`728`		`- static_assert(false, __FUNCTION__ ": not a noexcept callable functor returning void");`
	`733`	`+ static_assert(details::always_false<T>, __FUNCTION__ ": not a noexcept callable functor returning void");`
`729`	`734`	`}`
`730`	`735`
`731`	`736`	`template <typename TInvoke, typename TOnCancel>`