From b089375a956704bbb640b203832cc8271725adc2 Mon Sep 17 00:00:00 2001
From: Joey Parrish <joeyparrish@google.com>
Date: Mon, 20 Mar 2017 16:11:24 -0700
Subject: [PATCH] Improve NetworkingEngine test coverage

Change-Id: I6c3f6347e3d7e647b48bf8d1a3e7da9d7edf1859
---
 test/net/networking_engine_unit.js | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/test/net/networking_engine_unit.js b/test/net/networking_engine_unit.js
index e5cdef297f..1b859527f5 100644
--- a/test/net/networking_engine_unit.js
+++ b/test/net/networking_engine_unit.js
@@ -285,6 +285,23 @@ describe('NetworkingEngine', /** @suppress {accessControls} */ function() {
             done();
           });
     });
+
+    it('fills in defaults for partial request objects', function(done) {
+      var originalRequest = {
+        uris: ['resolve://foo']
+      };
+
+      resolveScheme.and.callFake(function(uri, request, requestTypePassed) {
+        // NetworkingEngine should have filled in these values:
+        expect(request.method).toBeTruthy();
+        expect(request.headers).toBeTruthy();
+        expect(request.retryParameters).toBeTruthy();
+
+        return Promise.resolve({});
+      });
+      networkingEngine.request(requestType, originalRequest)
+          .catch(fail).then(done);
+    });
   });
 
   describe('request filter', function() {
@@ -480,6 +497,11 @@ describe('NetworkingEngine', /** @suppress {accessControls} */ function() {
           })
           .then(done);
     });
+
+    it('causes no errors to remove an unused filter', function() {
+      var unusedFilter = jasmine.createSpy('unused filter');
+      networkingEngine.unregisterRequestFilter(unusedFilter);
+    });
   });
 
   describe('response filter', function() {
@@ -647,6 +669,11 @@ describe('NetworkingEngine', /** @suppress {accessControls} */ function() {
             done();
           });
     });
+
+    it('causes no errors to remove an unused filter', function() {
+      var unusedFilter = jasmine.createSpy('unused filter');
+      networkingEngine.unregisterResponseFilter(unusedFilter);
+    });
   });
 
   describe('destroy', function() {