Skip to content

Commit 5749735

Browse files
author
theron humiston
committed
remove recommended gurus limit
1 parent 05f6b0f commit 5749735

File tree

2 files changed

+1
-12
lines changed

2 files changed

+1
-12
lines changed

app/api/v1/followers.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ module API
33
module V1
44
class Followers < Grape::API
55
DEALS_LIMIT = 4.freeze
6-
RECOMMENDED_LIMIT = 8.freeze
76

87
get "/:userUuid/gurus" do
98
follower = Follower.find_by_user_uuid!(params[:userUuid])
@@ -27,7 +26,7 @@ class Followers < Grape::API
2726

2827
get "/recommended" do
2928
gurus = Guru.recommended(params[:userUuid])
30-
{ gurus: gurus.take(RECOMMENDED_LIMIT).sort_by(&:followers_count).reverse!.map { |guru| Presenters::GuruPresenter.new(guru).present } }
29+
{ gurus: gurus.sort_by(&:followers_count).reverse!.map { |guru| Presenters::GuruPresenter.new(guru).present } }
3130
end
3231
end
3332
end

spec/api/v1/followers_spec.rb

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,6 @@ def create_guru_with_followers(followers_count)
7575
expect(response_json[:gurus].first[:userUuid]).to eq(not_following.user_uuid)
7676
end
7777

78-
it "limits the results to 8" do
79-
follower_uuid = generate_uuid
80-
follower = Follower.create!({ user_uuid: follower_uuid })
81-
10.times { create_guru }
82-
83-
get("gurus_api/v1/followers/recommended?userUuid=#{follower_uuid}")
84-
expect(last_response.status).to eq(200)
85-
expect(response_json[:gurus].count).to be(8)
86-
end
87-
8878
it "returns all gurus when follower is not present" do
8979
8.times { create_guru }
9080

0 commit comments

Comments
 (0)