Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug related to changing to same view controller #12

Open
muvaf opened this issue Nov 20, 2016 · 1 comment
Open

Bug related to changing to same view controller #12

muvaf opened this issue Nov 20, 2016 · 1 comment

Comments

@muvaf
Copy link

muvaf commented Nov 20, 2016

Hi,

Thanks for the work! But, I noticed a bug. To replicate:

  1. Click menu button
  2. Select the same view controller option with the one you have now
  3. Click again to menu button and it doesn't work.
  4. Click again now it works but view is messed up.

Problem is with sender.tag use. I fixed it by checking iif (view.subviews.last?.restorationIdentifier == "SlideMenuView") insted of checking for sender's tag. That seemed cleaner and more generic to me and also fixed the problem.

Also I made slidemenuvc a property of BaseViewController so that it doesn't initialize every time.

@Raafas
Copy link

Raafas commented Jan 25, 2017

@bymafmaf send a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants