feat: rename set command's --parent flag to --parents
#2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrz
changed the title
Stratus3D
reviewed
Apr 8, 2025
CHANGELOG.md
Outdated
| @@ -8,7 +8,7 @@ | |||
| * remove comment from first line zsh completion output ([#2035](https://github.com/asdf-vm/asdf/issues/2035)) ([#2037](https://github.com/asdf-vm/asdf/issues/2037)) ([74d7b17](https://github.com/asdf-vm/asdf/commit/74d7b17a1cc9f640cf0f5134416d1cf7a56fe19f)) | |||
|
|
|||
| ## [0.16.6](https://github.com/asdf-vm/asdf/compare/v0.16.5...v0.16.6) (2025-03-21) | |||
|
|
|||
| * rename --parent argument to --parents ([#2010](https://github.com/asdf-vm/asdf/issues/2010)) | |||
There was a problem hiding this comment.
Please revert this change. CHANGELOG.md entries are added automatically.
Stratus3D
changed the title
--parent flag to --parents
jrz
force-pushed
the
rename-set-parent-to-parents
branch
from
e9d9354 to
89fbcd6
Compare
|
Reverted, and squashed some of the commits. First commit is for global renaming + a bit or rewording |
jrz
force-pushed
the
rename-set-parent-to-parents
branch
from
89fbcd6 to
9e3f67e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes --parent to --parents. Updated docs etc.
It adds a fallback --parent, but will warn about the change.
Note that the old option still appears in --help (Hence the Hidden: false in cli.go. That can be set to true, or just removed.)
Fixes: List issue numbers here
#2010 Consider renaming --parent to --parents
Other Information
Please check if you want the Hidden: true or not.
I noticed tests fail, but the same tests fail from a fresh master.
I couldn't really think of a test, as the option itself is only used as -p in the test.
Lastly, in the contribute/core.html I noticed the instructions said bats test/list_commands.bash instead of bats test/list_commands.bats