Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods from Options and Attributes #1199

Closed
abelsromero opened this issue May 9, 2023 · 3 comments · Fixed by #1200
Closed

Remove deprecated methods from Options and Attributes #1199

abelsromero opened this issue May 9, 2023 · 3 comments · Fixed by #1200
Milestone

Comments

@abelsromero
Copy link
Member

abelsromero commented May 9, 2023

New Builder methods have been available for several versions and I think it's time to remove them to simplify code.
The goals are:

  • Reduce code
  • Stream line the API: no more having multiple ways to create Options or Attributes.
    The only exception are the get() Map methods maintained for convinience.

This does not suppress #977, that was a good conversation and there's room to improve, this is just to remove what we already agree to clean code.

@abelsromero abelsromero added this to the 3.0.0 milestone May 9, 2023
@abelsromero
Copy link
Member Author

I think this could be the last milestone for v3.0.0? Or is there anything else that we should add?

@abelsromero
Copy link
Member Author

Working on it I see there are also the deprecated methods in the Asciidoctor interface, I'd rather deal with that in another PR. I'll create another issue to track tath.

@abelsromero
Copy link
Member Author

Found also methods in Document to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant