Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asciidoctor.convert() never returns Documents. #1175

Closed
robertpanzer opened this issue Apr 11, 2023 · 2 comments
Closed

Asciidoctor.convert() never returns Documents. #1175

robertpanzer opened this issue Apr 11, 2023 · 2 comments

Comments

@robertpanzer
Copy link
Member

As mentioned by @abelsromero in #1171 the method Asciidodctor.convert() never returns a Document, even though the caller asks for a org.asciidoctor.ast.Document.
The implementation of this method should use the NodeConverter and try to convert the result returned by Asciidoctor.
@abelsromero
Copy link
Member

Addressed in PR #1171, I think we can close this issue?

@robertpanzer
Copy link
Member Author

Yes, totally! Thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertpanzer @abelsromero