-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the kroki-default-options logic in the Ruby library #156
Comments
Can we use kroki in asciidoctor binary? Use it in asciidoctor.js is cool. I'd say, use kroki with vscode-asciidoctor, the experience is fabulous. But when you use hugo with asciidoc, you need asciidoctor to render adoc files, at this time, if you want diagram, you can't use kroki, because there is no kroki plugin with asciidoctor binary. Is it possible to use it with asciidoctor? |
Do you mean with the Asciidoctor (Ruby) CLI?
The JavaScript and Ruby implementation have a few differences but we are trying to fill the gap.
Reading Hugo documentation, I think you should add If it's working we should probably update the documentation to state that |
Checked the Hugo doc, asciidoctor-kroki not in the possible extensions of hugo, for now. A proposal has been raised: |
I have made a PR of hugo which tries to make asciidoctor-kroki a possible extension. Or, you can build the PR yourself for instant use of asciidoctor-kroki with hugo right now, below just the hugo serve output: INFO 2020/11/02 13:39:14 Rendering \c.adoc with C:\Ruby27-x64\bin\asciidoctor.bat using asciidoctor args [-r asciidoctor-html5s -r asciidoctor-kroki -a data-uri=1 -a kroki-server-url=https://XXX.com --base-dir C:\Users\roger\n\hugo\hugoTestSite\content -a outdir=C:\hugoTestSite\public\c --no-header-footer -] ... Part of rendered page: |
Yes, if the pull request is merged, then the workflow is flawless, and I will explain how to integrate it in Hugo. |
Currently, this feature is only available in JavaScript:
https://github.com/Mogztter/asciidoctor-kroki/blob/bca1ec83711989b0b1318222843eeac341e22c40/src/asciidoctor-kroki.js#L37-L59
The text was updated successfully, but these errors were encountered: