Improvements in the code#55
Merged
Merged
Conversation
- Add pattern matching with the where clause in the if statement improving clean syntax and improvements of Swift 2. - Change () for Void in every closure to improve the clarity in the code and following the guidelines of using closures in Swift. - Add two typealias to the closures in the function setObjectForKey() to improve reusability and readibility in the code .
- Add pattern matching with the where clause in the if statement improving clean syntax and improvements of Swift 2. - Change () for Void in every closure to improve the clarity in the code and following the guidelines of using closures in Swift. - Add two typealias to the closures in the function setObjectForKey() to improve reusability and readibility in the code .
Remove force unwrapping to avoid any runtime error, make a more secure code to runtime errors.
Change the do-catch statement error handling for creating an optional with wildcard.
- Change the regular expression for a more short syntax calling directly the function stringByReplacingOccurrencesOfString() with the regular expression. - Change do-catch statement with optional in case of error.
| /// Typealias to define the reusability in declaration of the closures. | ||
| public typealias cacheBlockClosure = (T, CacheExpiry) -> Void | ||
| public typealias errorClosure = (NSError?) -> Void | ||
|
|
Owner
There was a problem hiding this comment.
These should better start with a capital letter.
Owner
|
Thanks, just a minor remark, then I am happy to merge :) |
Contributor
Author
|
Done @aschuch , thanks for you quickly revision 😃 |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make improvements in the code and refactoring to improve readability and clean syntax.