Remove temporary variable from supported_features (home-assistant#42685)

* Remove temporary variable from supported_features

* Revert removing temp variable for supported features hunterdouglas

Author: springstan

homeassistant/components/ads/light.py

@@ -68,10 +68,9 @@ def brightness(self):
     @property
     def supported_features(self):
         """Flag supported features."""
-        support = 0
         if self._ads_var_brightness is not None:
-            support = SUPPORT_BRIGHTNESS
-        return support
+            return SUPPORT_BRIGHTNESS
+        return 0
 
     @property
     def is_on(self):

homeassistant/components/bond/light.py

@@ -68,11 +68,9 @@ def _apply_state(self, state: dict):
     @property
     def supported_features(self) -> Optional[int]:
         """Flag supported features."""
-        features = 0
         if self._device.supports_set_brightness():
-            features |= SUPPORT_BRIGHTNESS
-
-        return features
+            return SUPPORT_BRIGHTNESS
+        return 0
 
     @property
     def is_on(self) -> bool:

homeassistant/components/control4/light.py

@@ -187,10 +187,9 @@ def brightness(self):
     @property
     def supported_features(self) -> int:
         """Flag supported features."""
-        flags = 0
         if self._is_dimmer:
-            flags |= SUPPORT_BRIGHTNESS | SUPPORT_TRANSITION
-        return flags
+            return SUPPORT_BRIGHTNESS | SUPPORT_TRANSITION
+        return 0
 
     async def async_turn_on(self, **kwargs) -> None:
         """Turn the entity on."""

homeassistant/components/lcn/light.py

@@ -71,10 +71,9 @@ async def async_added_to_hass(self):
     @property
     def supported_features(self):
         """Flag supported features."""
-        features = SUPPORT_TRANSITION
         if self.dimmable:
-            features |= SUPPORT_BRIGHTNESS
-        return features
+            return SUPPORT_TRANSITION | SUPPORT_BRIGHTNESS
+        return SUPPORT_TRANSITION
 
     @property
     def brightness(self):

homeassistant/components/nest/camera_sdm.py

@@ -84,10 +84,9 @@ def model(self):
     @property
     def supported_features(self):
         """Flag supported features."""
-        features = 0
         if CameraLiveStreamTrait.NAME in self._device.traits:
-            features = features | SUPPORT_STREAM
-        return features
+            return SUPPORT_STREAM
+        return 0
 
     async def stream_source(self):
         """Return the source of the stream."""

homeassistant/components/spider/climate.py

@@ -44,12 +44,9 @@ def __init__(self, api, thermostat):
     @property
     def supported_features(self):
         """Return the list of supported features."""
-        supports = SUPPORT_TARGET_TEMPERATURE
-
         if self.thermostat.has_fan_mode:
-            supports |= SUPPORT_FAN_MODE
-
-        return supports
+            return SUPPORT_TARGET_TEMPERATURE | SUPPORT_FAN_MODE
+        return SUPPORT_TARGET_TEMPERATURE
 
     @property
     def unique_id(self):

homeassistant/components/tuya/cover.py

@@ -68,10 +68,9 @@ def __init__(self, tuya, platform):
     @property
     def supported_features(self):
         """Flag supported features."""
-        supported_features = SUPPORT_OPEN | SUPPORT_CLOSE
         if self._tuya.support_stop():
-            supported_features |= SUPPORT_STOP
-        return supported_features
+            return SUPPORT_OPEN | SUPPORT_CLOSE | SUPPORT_STOP
+        return SUPPORT_OPEN | SUPPORT_CLOSE
 
     @property
     def is_opening(self):

homeassistant/components/tuya/fan.py

@@ -119,7 +119,6 @@ def speed_list(self) -> list:
     @property
     def supported_features(self) -> int:
         """Flag supported features."""
-        supports = SUPPORT_SET_SPEED
         if self._tuya.support_oscillate():
-            supports = supports | SUPPORT_OSCILLATE
-        return supports
+            return SUPPORT_SET_SPEED | SUPPORT_OSCILLATE
+        return SUPPORT_SET_SPEED

homeassistant/components/xbox/media_player.py

@@ -111,10 +111,9 @@ def state(self):
     @property
     def supported_features(self):
         """Flag media player features that are supported."""
-        active_support = SUPPORT_XBOX
         if self.state not in [STATE_PLAYING, STATE_PAUSED]:
-            active_support &= ~SUPPORT_NEXT_TRACK & ~SUPPORT_PREVIOUS_TRACK
-        return active_support
+            return SUPPORT_XBOX & ~SUPPORT_NEXT_TRACK & ~SUPPORT_PREVIOUS_TRACK
+        return SUPPORT_XBOX
 
     @property
     def media_content_type(self):