Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will there be a GA or Production ready version for Conversational Search as it says experimental #11

Open
ramda1234786 opened this issue Jan 27, 2024 · 7 comments

Comments

@ramda1234786
Copy link

Will there be a GA or Production ready version for Conversational Search as it says experimental ?
Also from where i can test the new version as this repository does not have any new code, i see nothing in opensearch-ml comms also
apart from this one https://github.com/opensearch-project/ml-commons/blob/main/memory/src/main/java/org/opensearch/ml/memory/ConversationalMemoryHandler.java

Also do we have any documentation to do initial testing on 2.12

Thanks in advance for information
RamDa

@HenryL27
Copy link
Collaborator

the conversation search feature should be GA for 2.12 - it's in app security / pentesting now.

probably the best way to test it is with the staging docker image. The documentation hasn't been updated yet, so unfortunately the best documentation may be github issues and code in ml-commons... sorry about that. This file has all the memory endpoints in it. The RAG pipeline hasn't (afaik) changed

@HenryL27
Copy link
Collaborator

git blame can maybe help find the relevant issues

@ramda1234786
Copy link
Author

ramda1234786 commented Jan 29, 2024

Thanks @HenryL27 , i was trying the post_process_function, i tried to take help from various sources but no luck.
Now i am wondering if there is no changes in RAG files even with GA looks like my solution will not work.

I have tried with langchain but that does not support hybrid search. So unfortunately i am not able to move forward

opensearch-project/ml-commons#1925 (comment)

@mashah
Copy link

mashah commented Jan 29, 2024

Version 2.12 is still under development. If you need RAG with OpenSearch my recommendation is to try Sycamore. We know that path works, though it's using 2.11. Once 2.12 is ready, we will have that working with Sycamore as well.

@ramda1234786
Copy link
Author

Thanks for your input, my problem is not in data ingestion but using "post_process_function": "\n return params['response'][0].generated_text; \n"

I have this

[
    {
        "generated_text": "Your Generated text"
    }
]

and i want to convert it to this below using post process fuction

  {
       "completion": "Your Generated text"
   }

I have tried this till now

"post_process_function": "\n def json = \"{\" +\n \"\\\"completion\\\":\\\"\" + params['response'][0].generated_text + \"\\\" }\";\n return json;\n "

But it never works with _predict APIs

@ylwu-amzn
Copy link

@ramda1234786 Can you cut an issue in ml-commons repo for this process function error https://github.com/opensearch-project/ml-commons/issues

@ramda1234786
Copy link
Author

Hi @ylwu-amzn , i have added here opensearch-project/ml-commons#1990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants