Revision#1
Merged
Merged
Conversation
fabianfett
reviewed
Aug 13, 2024
| The proposed design of passing a `LambdaResponseWriter` as an argument to the `handle` function of objects conforming to | ||
| `StreamingLambdaHandler` already allows for background tasks to be run _after_ the response has been returned. This is | ||
| because the `handle(...)` function is free to implement any background task that needs to be run after calling the | ||
| `LambdaResponseWriter.finish()` function (which sends the computed result to the AWS Lambda response endpoint). |
There was a problem hiding this comment.
Also users are able to spawn async work in structured way. They can start TaskGroups or schedule work using async let (both of which are totally structured).
fabianfett
reviewed
Aug 14, 2024
fabianfett
reviewed
Aug 14, 2024
fabianfett
reviewed
Aug 14, 2024
fabianfett
reviewed
Aug 14, 2024
fabianfett
reviewed
Aug 19, 2024
fabianfett
reviewed
Aug 19, 2024
| /// report an error to the invoker. | ||
| /// - context: The LambdaContext containing the invocation's metadata | ||
| mutating func handle(_ event: ByteBuffer, responseWriter: consuming some LambdaResponseWriter, context: LambdaContext) async | ||
| /// - Throws |
There was a problem hiding this comment.
Suggested change
| /// - Throws | |
| /// - Throws: |
There was a problem hiding this comment.
fabianfett
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.