feat(test): create git test run --search option
#777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arxanas
force-pushed
the
arxanas/test
branch
3 times, most recently
from
430f121 to
ccb297a
Compare
arxanas
changed the title
search modulescm-bisect crate
arxanas
force-pushed
the
arxanas/test
branch
6 times, most recently
from
3a5a690 to
f4bcdf9
Compare
arxanas
changed the title
scm-bisect crategit test run --search option
arxanas
force-pushed
the
arxanas/test
branch
from
f4bcdf9 to
077c683
Compare
epage
reviewed
Feb 10, 2023
arxanas
force-pushed
the
arxanas/test
branch
2 times, most recently
from
81f4793 to
071244a
Compare
Fortunately, no bugs were detected at this stage. I was able to detect a previous bug I had committed when artificially reintroducing it.
This way, we can also use the caller's trait and lifetime bounds. This was necessary because the calling code previously didn't know that the contained `dyn Error` was `Send`.
- At the end of the search, the caller wants to get the search bounds without caring about `next_to_search`. - In the future, we may have different kinds of bounds. For example, we could track bounds where *any* monotonic function (with respect to ancestry on the DAG) changes value, instead of just boolean success and failure.
arxanas
force-pushed
the
arxanas/test
branch
from
071244a to
0be82eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.