Skip to content

Conversation

@arxanas
Copy link
Owner

@arxanas arxanas commented Nov 14, 2022

No description provided.

@arxanas arxanas changed the base branch from master to arxanas/build November 14, 2022 08:10
@arxanas arxanas marked this pull request as ready for review November 14, 2022 08:17
Base automatically changed from arxanas/build to master November 14, 2022 08:39
We already have a mechanism for commit replacement for merge commits specifically, to handle cases where we couldn't compute the merge from scratch (and where the result of the merge should be the same anyways). This commit generalizes the mechanism to work for all kinds of commits, so that we can replace arbitrary commits with different trees without reapplying patches.

I think this also fixes a bug in merge commits where the parent order was not preserved when conducting a new merge.
This option rewrites the tree for the current commit while leaving all descendant commits the same. This can be useful when applying formatting or refactoring changes to a given commit for which you would rather adjust the descendant commits manually than try to merge the conflicting changes.
@arxanas arxanas enabled auto-merge (rebase) November 14, 2022 16:53
@arxanas arxanas disabled auto-merge November 14, 2022 16:54
@arxanas
Copy link
Owner Author

arxanas commented Nov 14, 2022

cc @claytonrcarter

@arxanas arxanas merged commit 81657ee into master Nov 14, 2022
@arxanas arxanas deleted the arxanas/amend2 branch November 14, 2022 20:29
@claytonrcarter
Copy link
Collaborator

Sorry to be late here. I glanced at this earlier and it looked good to me, fwiw.

@arxanas
Copy link
Owner Author

arxanas commented Nov 15, 2022

@claytonrcarter no worries, I was just trying to keep you up to date in case it affected your --fixup PR 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants