Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Forest dashboard #16

Merged
merged 6 commits into from
Jun 22, 2023
Merged

Add Forest dashboard #16

merged 6 commits into from
Jun 22, 2023

Conversation

yilinxia
Copy link
Member

@yilinxia yilinxia commented Jun 6, 2023

add forest_dashboard including

  • model selection
  • Forest Plot
  • Ridget Plot
  • Add rope based model , data variable and coordinate variable

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

arviz_dashboard/__init__.py Show resolved Hide resolved
arviz_dashboard/forest.py Outdated Show resolved Hide resolved
arviz_dashboard/forest.py Outdated Show resolved Hide resolved
arviz_dashboard/forest.py Outdated Show resolved Hide resolved
arviz_dashboard/forest.py Outdated Show resolved Hide resolved
arviz_dashboard/forest.py Outdated Show resolved Hide resolved
arviz_dashboard/forest.py Outdated Show resolved Hide resolved
arviz_dashboard/forest.py Outdated Show resolved Hide resolved
arviz_dashboard/forest.py Outdated Show resolved Hide resolved
arviz_dashboard/forest.py Show resolved Hide resolved
@ndmlny-qs
Copy link
Contributor

We need to update the notebook to save the log likelihood in the inference data object. We should also pin panel in the requirements file to be less than 1 so we get the right version of bokeh installed.

@yilinxia I think we can merge after those changes.

@yilinxia
Copy link
Member Author

@ndmlny-qs Hi Andy, I have addressed the issues you pointed out. Meanwhile, I am also thinking about maybe we should use the same standard to “beautify” the code I wrote before (in another branch?)

@ndmlny-qs
Copy link
Contributor

I agree, we need to have steps that incorporate pre-commit for linting, typing and formatting; and ensure those items are done in the GitHub actions. I would say (for now) that we can squash and merge this, and work on a dev protocol in the readme. We can use some of what is talked about in ArviZ's contributing page as a guide

Copy link
Contributor

@ndmlny-qs ndmlny-qs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yilinxia
Copy link
Member Author

yilinxia commented Jun 19, 2023

@aloctavodia Hi Osvaldo, do you have any other comments? otherwise, I think we can merge this branch

@aloctavodia aloctavodia merged commit d145b34 into main Jun 22, 2023
@aloctavodia aloctavodia deleted the forest_dashboard branch June 22, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants