Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android builds fail to compile saf_wrapper on Android NDK r22 #5

Closed
tanersener opened this issue Jan 17, 2021 · 1 comment
Closed
Assignees
Labels
android Affect Android platform development-branch Affects development branch fixed-in-v4.4 Fixed in release v4.4 incompatibility mobile-ffmpeg Originates from MobileFFmpeg scripts Affect build scripts

Comments

@tanersener
Copy link
Collaborator

tanersener commented Jan 17, 2021

Compilation of saf_wrapper.c fails for arm64-v8a architecture on macOS Android NDK r22.

jni/../app/src/main/cpp/saf_wrapper.c:41:14: error: cast to smaller integer type 'int' from 'void *' [-Werror,-Wvoid-pointer-to-int-cast]
    int fd = (int)opaque;
             ^~~~~~~~~~~
jni/../app/src/main/cpp/saf_wrapper.c:46:14: error: cast to smaller integer type 'int' from 'void *' [-Werror,-Wvoid-pointer-to-int-cast]
    int fd = (int)opaque;
             ^~~~~~~~~~~
jni/../app/src/main/cpp/saf_wrapper.c:51:14: error: cast to smaller integer type 'int' from 'void *' [-Werror,-Wvoid-pointer-to-int-cast]
    int fd = (int)opaque;
             ^~~~~~~~~~~
jni/../app/src/main/cpp/saf_wrapper.c:93:18: error: cast to smaller integer type 'int' from 'void *' [-Werror,-Wvoid-pointer-to-int-cast]
        int fd = (int)ctx->opaque;
                 ^~~~~~~~~~~~~~~~
4 errors generated.
@tanersener tanersener self-assigned this Jan 17, 2021
@tanersener tanersener added incompatibility enhancement New feature or request labels Jan 17, 2021
@tanersener tanersener changed the title Android builds fail on Android NDK r22 Android builds fail to compile saf_wrapper on Android NDK r22 Jan 17, 2021
@tanersener
Copy link
Collaborator Author

Fixed in v4.4 and v4.4.LTS.

@tanersener tanersener added the fixed-in-v4.4 Fixed in release v4.4 label Mar 7, 2021
@tanersener tanersener added mobile-ffmpeg Originates from MobileFFmpeg development-branch Affects development branch android Affect Android platform scripts Affect build scripts and removed enhancement New feature or request labels May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Affect Android platform development-branch Affects development branch fixed-in-v4.4 Fixed in release v4.4 incompatibility mobile-ffmpeg Originates from MobileFFmpeg scripts Affect build scripts
Projects
None yet
Development

No branches or pull requests

1 participant