From 9bcaed34992b33658a6221f8c66000fc8c8a7716 Mon Sep 17 00:00:00 2001
From: arstercz <arstercz@gmail.com>
Date: Sun, 5 Mar 2023 10:26:16 +0000
Subject: [PATCH] merge issue-10491, but only stats_helpers.go file

---
 plugins/inputs/docker/docker_test.go   |  2 +-
 plugins/inputs/docker/stats_helpers.go | 21 ++++++++++++++++++++-
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/plugins/inputs/docker/docker_test.go b/plugins/inputs/docker/docker_test.go
index 2c50e27cfd92b..a4704e77028f9 100644
--- a/plugins/inputs/docker/docker_test.go
+++ b/plugins/inputs/docker/docker_test.go
@@ -104,7 +104,7 @@ var baseClient = MockClient{
 	},
 	CloseF: func() error {
 		return nil
-	}
+	},
 }
 
 func newClient(host string, tlsConfig *tls.Config) (Client, error) {
diff --git a/plugins/inputs/docker/stats_helpers.go b/plugins/inputs/docker/stats_helpers.go
index 982f131d6d8d3..16ea2183e6b19 100644
--- a/plugins/inputs/docker/stats_helpers.go
+++ b/plugins/inputs/docker/stats_helpers.go
@@ -41,8 +41,27 @@ func calculateCPUPercentWindows(v *types.StatsJSON) float64 {
 
 // CalculateMemUsageUnixNoCache calculate memory usage of the container.
 // Page cache is intentionally excluded to avoid misinterpretation of the output.
+//
+// On Docker 19.03 and older, the result is `mem.Usage - mem.Stats["cache"]`.
+// On new docker with cgroup v1 host, the result is `mem.Usage - mem.Stats["total_inactive_file"]`.
+// On new docker with cgroup v2 host, the result is `mem.Usage - mem.Stats["inactive_file"]`.
+//
+// This definition is designed to be consistent with past values and the latest docker CLI
+// * https://github.com/docker/cli/blob/6e2838e18645e06f3e4b6c5143898ccc44063e3b/cli/command/container/stats_helpers.go#L239
 func CalculateMemUsageUnixNoCache(mem types.MemoryStats) float64 {
-	return float64(mem.Usage - mem.Stats["cache"])
+	// Docker 19.03 and older
+	if v, isOldDocker := mem.Stats["cache"]; isOldDocker && v < mem.Usage {
+		return float64(mem.Usage - v)
+	}
+	// cgroup v1
+	if v, isCgroup1 := mem.Stats["total_inactive_file"]; isCgroup1 && v < mem.Usage {
+		return float64(mem.Usage - v)
+	}
+	// cgroup v2
+	if v := mem.Stats["inactive_file"]; v < mem.Usage {
+		return float64(mem.Usage - v)
+	}
+	return float64(mem.Usage)
 }
 
 func CalculateMemPercentUnixNoCache(limit float64, usedNoCache float64) float64 {