[REV] sale: avoid prices recomputation

This reverts commit 789186a.
The fix is not necessary in 17+ since the new onchange only
sends the necessary information and not the whole x2m record
data.

closes odoo#155550

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Author: Feyensv

addons/sale/models/sale_order_line.py

@@ -1001,12 +1001,6 @@ def write(self, values):
                     precision_digits=precision
                 ) != 0
             )._update_line_quantity(values)
-            if len(self) == 1 and float_compare(
-                self.product_uom_qty,
-                values['product_uom_qty'],
-                precision_digits=precision
-            ) == 0:
-                values.pop('product_uom_qty')
 
         # Prevent writing on a locked SO.
         protected_fields = self._get_protected_fields()

addons/sale_stock/tests/test_sale_stock.py

@@ -1,14 +1,11 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
-
 from datetime import datetime, timedelta
 
-from freezegun import freeze_time
-
 from odoo import Command
 from odoo.exceptions import UserError
 from odoo.tests import Form, tagged
 
-from odoo.addons.sale.tests.common import SaleCommon, TestSaleCommon
+from odoo.addons.sale.tests.common import TestSaleCommon
 from odoo.addons.stock_account.tests.test_anglo_saxon_valuation_reconciliation_common import (
     ValuationReconciliationTestCommon,
 )
@@ -1755,38 +1752,3 @@ def test_delivery_on_negative_delivered_qty(self):
         picking.button_validate()
         self.assertEqual(sale_order.order_line.qty_delivered, -1.0)
         self.assertEqual(sale_order.order_line.qty_to_invoice, -1.0)
-
-
-class TestSaleOrder(SaleCommon):
-
-    @freeze_time('2017-01-07')
-    def test_order_onchange(self):
-        order = self.empty_order
-        storable_product = self.env['product.product'].create({
-            'name': 'Test Storable',
-            'type': 'product',
-            'list_price': 25.0,
-        })
-        order.order_line = [
-            Command.create({
-                'product_id': storable_product.id,
-                'product_uom_qty': 15.12,
-                'price_unit': 50.0,
-            }),
-        ]
-        # retrieve the onchange spec for calling 'onchange'
-        order_form = Form(order)
-        # spec = order_form._view['onchange']
-        # onchange_vals = order_form._onchange_values()
-        # res = order.onchange(
-        #     dict(
-        #         onchange_vals,
-        #         commitment_date='2017-01-12',
-        #     ),
-        #     'commitment_date',
-        #     spec
-        # )
-        # self.assertEqual(res['value']['order_line'][1][2]['product_uom_qty'], 15.12)
-        order_form.commitment_date = '2017-01-12'
-        order_form.save()
-        self.assertEqual(order.order_line.price_unit, 50.0)