[FIX] mail: fix non deterministic bus subscription test

Before this PR, the `bus subscription is refreshed when channel is
left` test was sometimes failing. This actually reveals a real issue:
if a channel is joined a leave very quickly, the bus subscription is
not updated.

This occurs because we rely on the last subscription made and the one
that should be made to detect if channels differ. Since the
`updateBusSubscription` method is debounced, we can miss information.

This PR replaces the complicated `updateBusSubscription` method by a
`onAdd/onDelete`. This is much more reliable and more efficient since
there is no need to walk through every channel to detect changes.

This PR also remove a test that was redundant that the failing one.

fixes runbot-55292,57645,56232

closes odoo#155720

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Author: tsm-odoo

addons/mail/static/src/core/common/channel_member_model.js

@@ -48,7 +48,7 @@ export class ChannelMember extends Record {
     }
 
     get memberSince() {
-        return deserializeDateTime(this.create_date);
+        return this.create_date ? deserializeDateTime(this.create_date) : undefined;
     }
 }
 

addons/mail/static/src/core/common/store_service.js

@@ -185,38 +185,10 @@ export class Store extends BaseStore {
 
     setup() {
         super.setup();
-        this.updateBusSubscription = debounce(this.updateBusSubscription, 0); // Wait for thread fully inserted.
-    }
-
-    updateBusSubscription() {
-        if (!this.isMessagingReady) {
-            return;
-        }
-        const allSelfChannelIds = new Set();
-        for (const thread of Object.values(this.Thread.records)) {
-            if (thread.model === "discuss.channel" && thread.hasSelfAsMember) {
-                if (thread.selfMember.memberSince < this.env.services["bus_service"].startedAt) {
-                    this.knownChannelIds.add(thread.id);
-                }
-                allSelfChannelIds.add(thread.id);
-            }
-        }
-        let shouldUpdateChannels = false;
-        for (const id of allSelfChannelIds) {
-            if (!this.knownChannelIds.has(id)) {
-                shouldUpdateChannels = true;
-                this.knownChannelIds.add(id);
-            }
-        }
-        for (const id of this.knownChannelIds) {
-            if (!allSelfChannelIds.has(id)) {
-                shouldUpdateChannels = true;
-                this.knownChannelIds.delete(id);
-            }
-        }
-        if (shouldUpdateChannels) {
-            this.env.services["bus_service"].forceUpdateChannels();
-        }
+        this.updateBusSubscription = debounce(
+            () => this.env.services.bus_service.forceUpdateChannels(),
+            0
+        );
     }
 }
 Store.register();
@@ -231,7 +203,6 @@ export const storeService = {
         const store = makeStore(env);
         store.discuss = {};
         store.discuss.activeTab = "main";
-        Record.onChange(store.Thread, "records", () => store.updateBusSubscription());
         services.ui.bus.addEventListener("resize", () => {
             store.discuss.activeTab = "main";
             if (

addons/mail/static/src/core/common/thread_model.js

@@ -38,7 +38,6 @@ export class Thread extends Record {
                 thread.isLoadedDeferred.then(() => def.resolve());
             }
         });
-        Record.onChange(thread, "channelMembers", () => this.store.updateBusSubscription());
         return thread;
     }
     /**
@@ -178,6 +177,17 @@ export class Thread extends Record {
             this._store.discuss.ringingThreads.delete(this);
         },
     });
+    toggleBusSubscription = Record.attr(false, {
+        compute() {
+            return (
+                this.model === "discuss.channel" &&
+                this.selfMember?.memberSince >= this._store.env.services.bus_service.startedAt
+            );
+        },
+        onUpdate() {
+            this._store.updateBusSubscription();
+        },
+    });
     invitedMembers = Record.many("ChannelMember");
     chatPartner = Record.one("Persona");
     composer = Record.one("Composer", { inverse: "thread", onDelete: (r) => r.delete() });

addons/mail/static/src/discuss/core/common/discuss_core_common_service.js

@@ -31,7 +31,6 @@ export class DiscussCoreCommon {
 
     setup() {
         this.messagingService.isReady.then((data) => {
-            this.store.updateBusSubscription();
             Record.MAKE_UPDATE(() => {
                 for (const channelData of data.channels) {
                     this.insertInitChannel(channelData);

addons/mail/static/tests/crosstab/crosstab_tests.js

@@ -1,7 +1,6 @@
 /* @odoo-module */
 
 import { startServer } from "@bus/../tests/helpers/mock_python_environment";
-import { waitUntilSubscribe } from "@bus/../tests/helpers/websocket_event_deferred";
 
 import { start } from "@mail/../tests/helpers/test_utils";
 
@@ -110,17 +109,6 @@ QUnit.test("Channel subscription is renewed when channel is added from invite",
     await assertSteps(["update-channels"]);
 });
 
-QUnit.test("Channel subscription is renewed when channel is left", async () => {
-    const pyEnv = await startServer();
-    pyEnv["discuss.channel"].create({ name: "Sales" });
-    const { openDiscuss } = await start();
-    await waitUntilSubscribe();
-    openDiscuss();
-    await click(".o-mail-DiscussSidebarChannel .btn[title='Leave this channel']");
-    await contains(".o-mail-DiscussSidebarChannel", { count: 0 });
-    await waitUntilSubscribe();
-});
-
 QUnit.test("Adding attachments", async () => {
     const pyEnv = await startServer();
     const channelId = pyEnv["discuss.channel"].create({ name: "Hogwarts Legacy" });