-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Powerline Glyph for Git Branch #351
Comments
This is a good idea, thanks! It looks like the Windows Terminal doesn’t yet support fallback fonts, but maybe it would be helpful to upvote/add a reaction to it at microsoft/terminal#1790 to encourage that effort. :) |
Note for later: seems like https://github.com/ryanoasis/nerd-fonts might be a way to do this |
Notes: There are fewer powerline glyphs that I realized – I thought they might include a lot of box-drawing glyphs, but it is basically 8 useful glyphs, then a bunch of glyphs that seem to be purely for ... style? From nerd fonts powerline fonts, here is the basic set: ...and the "extras": A screenshot from the powerline website shows some of these in context, as elements that are seemingly just for decoration (rather than system status, etc): From Cascadia Code, here is the glyph set, adapted to fit within single-width units: If/when I add these to Recursive, I would have a few goals:
It might be helpful to use the Cascadia Code merging approach: def step_merge_glyphs_from_ufo(path):
def _merge(instance):
ufo = ufoLib2.Font.open(path)
print(f"[{instance.info.familyName} {instance.info.styleName}] Merging {path}")
for glyph in ufo.glyphOrder:
if glyph not in instance.glyphOrder:
instance.addGlyph(ufo[glyph])
return _merge ...though, I also want to look at merging TTFs with FontTools. Which, actually might be super easy with the FontTools merge tool! |
Design steps: Make a branch
|
We’ve made some good progress here with the PR #407. Next, I will work on a way to add this into the build system for Rec Mono fonts (e.g. https://github.com/arrowtype/recursive-code-config). |
Approach I’ll try here:
|
This is partly working! I have a starter script here: https://github.com/arrowtype/recursive-code-config/blob/5260e83be9669e6e6cce4ea1e89510af6d11462f/scripts/merge-powerline-ttfs.py However, there is a funny (slightly stupid on my part) mistake preventing the "branch" glyph from display with Recursive: the glyph already exists in the fonts, but only as a blank glyph (basically like a word space). This is probably because I added the glyph earlier, with the intention of filling it with an Recursive-specific branch drawing. However, this results in that icon showing up as a blank space, if Recursive is used with a PowerLine theme. 💀 The fix is simple but will take a bit of time to allow for a new build & release. I will:
I think this might be all it takes! 🤞 Or, it might take more investigation. |
Got it working at a simple level! I still need to:
|
Technical notes on the TLDR: In , the Me:
Aaron Bell:
|
It would be really nice to have the box-drawing glyphs, perhaps this could be useful? https://github.com/adobe-type-tools/box-drawing |
@otherjoel I agree, but that should probably be a new issue. Box drawing glpyhs are in a different category that Powerline stuff. |
Hello @arrowtype, thanks for implementing this request, Would you like to keep this issue open or do you think I can close this issue based on 1.066 release? |
Thanks, @krish-r! I will keep this open for now, as I still want to implement different sizing of the power line glyphs likely to show up in certain terminals such as the integrated terminal in VS Code. |
Digging into this further, it seems like this is a VS Code issue, which is also affecting fonts like Cascadia Code & Fira Code (and many others). In turn, this seems to maaaybe be a Chrome text rendering issue. The alignment is very good in the macOS Terminal and in iTerm2, so I will close this issue, and make a new issue to investigate whether there is a reasonable fix I can do on my end for VS Code alignment. macOS Terminal: iTerm2: |
BTW, per some of my investigations, it appears that Windows Terminal is not turning on the |
(Also you're inspiring me to go back and improve some of those ugly glyphs :) ) |
Thanks for documenting another obscure font issue Stephen! I was looking up what the deal was with Powerline symbols was and didn't understand the meaning of the 'extra' set. |
Hi,
Could you please consider adding the powerline glyph for git branch if possible?
OS: Windows 10
Terminal: VS Code Integrated terminal
Recursive Version: v1.051
Cascadia Code:
Recursive Mono:
Thanks
The text was updated successfully, but these errors were encountered: