-
-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add py.typed export per PEP 561 #925
Conversation
So that type testing tools like mypy can actually use type annotations
Codecov Report
@@ Coverage Diff @@
## master #925 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1896 1896
Branches 311 311
=========================================
Hits 1896 1896 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I had a quick question @maroux. If PEP 561 is Python 3.7+ compatible, will mypy not detect the typings in Python 3.6?
@jadchaar possible? At least for mypy, it looks like it supports
I think for PEPs that don't add features to python core, the |
@isac322 you might be more familiar with PEP 561 for type annotations. Think this is good to merge? |
@jadchaar Yep I forgot to add this 😅 |
All good, just wanted to make sure! |
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
tox
ormake test
to find out!).tox -e lint
ormake lint
to find out!).master
branch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
Add
py.typed
file and export type annotations per PEP 561 so that type testing tools like mypy can actually verify types when using arrow.No new test added for this change and I don't think there's any documentation necessary but let me know if something needs to be added.