Skip to content

Conversation

@yajra
Copy link
Contributor

@yajra yajra commented Aug 24, 2016

On Laravel 5.3, parenthesis on expressions are automatically stripped.

laravel/framework#14986
https://laravel.com/docs/5.3/upgrade

@yajra
Copy link
Contributor Author

yajra commented Aug 24, 2016

BTW, this is a breaking change so you might need to bump a major version for Laravel 5.3? Thanks!

@arrilot
Copy link
Owner

arrilot commented Aug 24, 2016

Could we detect Laravel version and register directives depending on it to avoid brealing changes?
We need to support L5.1 LTS as well and I want to avoidcreating and maintaining separate branches

@pherum
Copy link

pherum commented Aug 24, 2016

@arrilot This fix should work on all versions.
it was originally incorrectly was identified.
Output was about it

...->run'widget'

and need just the same code like this

...->run('widget')

alternatively, you can make a new branch

@arrilot arrilot merged commit 8a30b25 into arrilot:master Aug 24, 2016
@arrilot
Copy link
Owner

arrilot commented Aug 24, 2016

I've merged and added a check myself.
Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants