Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with normalization and prediction #8

Open
ozanozyegen opened this issue Feb 9, 2021 · 0 comments
Open

Issues with normalization and prediction #8

ozanozyegen opened this issue Feb 9, 2021 · 0 comments

Comments

@ozanozyegen
Copy link

There are at least two significant issues in this implementation. Until they are fixed, don't use this repo unless you really know what you are doing. These issues are:

1-Normalization is not done properly. The current implementation applies normalization to the batch, not to the dataset.
This is problematic because:

  • Similar values are represented differently in different samples.
  • Causes data leakage, information about future values are leaked through the normalization

2-get_sample_prediction function does not do forecasting with the predicted values. The original paper uses the true values for training and the predicted values for the testing. Currently, there is no Monte Carlo sampling based forecasting function implemented in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant