Fixing DPI issues | Removed UseLayoutRounding and SnapToDevicePixels

Author: aronium

Aronium.Wpf.Toolkit/Themes/CalloutStyle.xaml

@@ -11,8 +11,6 @@
         <Setter Property="CornerRadius" Value="3" />
         <Setter Property="Padding" Value="12,15" />
         <Setter Property="VerticalContentAlignment" Value="Center" />
-        <Setter Property="SnapsToDevicePixels" Value="False" />
-        <Setter Property="UseLayoutRounding" Value="True" />
         <Setter Property="Template">
             <Setter.Value>
                 <ControlTemplate TargetType="{x:Type local:Callout}">

Aronium.Wpf.Toolkit/Themes/ClosableTabControlStyle.xaml

@@ -217,7 +217,9 @@
 
                 <ContentPresenter Content="{TemplateBinding Header}" />
 
+                <!--Use negative bottom margin to eliminate wierd empty space between scroll viewer and the bottom border--> 
                 <ScrollViewer x:Name="PART_ScrollViewer" 
+                              Margin="0, 0, 0, -1"
                               Grid.Column="1"
                               CanContentScroll="True" 
                               Background="Transparent" 
@@ -226,7 +228,7 @@
                     <TabPanel x:Name="HeaderPanel"
                               IsItemsHost="True"
                               Panel.ZIndex="10"
-                              Margin="0,-1"
+                              Margin="0"
                               KeyboardNavigation.TabIndex="1"
                               Background="Transparent" />
                 </ScrollViewer>
@@ -284,7 +286,8 @@
 
                 <Border BorderBrush="{TemplateBinding BorderBrush}" 
                         Grid.ColumnSpan="5"
-                        BorderThickness="0,2,0,0" Grid.Row="1">
+                        BorderThickness="0,2,0,0" 
+                        Grid.Row="1">
                     <ContentPresenter x:Name="PART_SelectedContentHost" 
                                       Margin="{TemplateBinding Padding}" 
                                       SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}"
@@ -298,7 +301,6 @@
         <Setter Property="Background" Value="{DynamicResource BackgroundBrush}" />
         <Setter Property="Foreground" Value="{DynamicResource Foreground}" />
         <Setter Property="BorderBrush" Value="{DynamicResource Accent}" />
-        <Setter Property="SnapsToDevicePixels" Value="True" />
         <Style.Triggers>
             <Trigger Property="TabStripPlacement" Value="Top">
                 <Setter Property="Template" Value="{StaticResource TabControlTemplate}" />

Aronium.Wpf.Toolkit/Themes/ComboBoxStyle.xaml

@@ -85,7 +85,6 @@
         <Setter Property="Height" Value="24" />
         <Setter Property="FocusVisualStyle" Value="{x:Null}" />
         <Setter Property="Validation.ErrorTemplate" Value="{x:Null}" />
-        <Setter Property="SnapsToDevicePixels" Value="True" />
         <Setter Property="Padding" Value="5,3,23,3" />
         <Setter Property="VerticalContentAlignment" Value="Center" />
         <Setter Property="Template">

Aronium.Wpf.Toolkit/Themes/FlyoutStyle.xaml

@@ -7,7 +7,6 @@
     <Style TargetType="{x:Type local:Flyout}">
         <Setter Property="Foreground" Value="{DynamicResource Foreground}" />
         <Setter Property="Background" Value="{DynamicResource BackgroundBrush}" />
-        <Setter Property="SnapsToDevicePixels" Value="True" />
         <Setter Property="Template">
             <Setter.Value>
                 <ControlTemplate TargetType="local:Flyout">

Aronium.Wpf.Toolkit/Themes/NumericUpDownStyle.xaml

@@ -9,7 +9,6 @@
         <Setter Property="Opacity" Value="1" />
         <Setter Property="Padding" Value="4,0" />
         <Setter Property="Margin" Value="0" />
-        <Setter Property="UseLayoutRounding" Value="True" />
         <Setter Property="FocusVisualStyle" Value="{x:Null}" />
         <Setter Property="Template">
             <Setter.Value>

Aronium.Wpf.Toolkit/Themes/ScrollBarStyle.xaml

@@ -7,7 +7,6 @@
     <Thickness x:Key="HorizontalDefaultMargin">0,3,0,0</Thickness>
 
     <Style x:Key="ScrollBarLineButton" TargetType="{x:Type RepeatButton}">
-        <Setter Property="SnapsToDevicePixels" Value="True"/>
         <Setter Property="OverridesDefaultStyle" Value="true"/>
         <Setter Property="Focusable" Value="false"/>
         <Setter Property="Template">
@@ -41,7 +40,6 @@
     </Style>
 
     <Style x:Key="ScrollBarPageButton" TargetType="{x:Type RepeatButton}">
-        <Setter Property="SnapsToDevicePixels" Value="True"/>
         <Setter Property="OverridesDefaultStyle" Value="true"/>
         <Setter Property="IsTabStop" Value="false"/>
         <Setter Property="Focusable" Value="false"/>
@@ -56,7 +54,6 @@
     </Style>
 
     <Style x:Key="ScrollBarThumb" TargetType="{x:Type Thumb}">
-        <Setter Property="SnapsToDevicePixels" Value="True"/>
         <Setter Property="OverridesDefaultStyle" Value="True"/>
         <Setter Property="IsTabStop" Value="false"/>
         <Setter Property="Focusable" Value="false"/>
@@ -177,7 +174,6 @@
 
     <Style TargetType="{x:Type ScrollBar}">
         <Setter Property="BorderThickness" Value="0"/>
-        <Setter Property="SnapsToDevicePixels" Value="True"/>
         <Setter Property="OverridesDefaultStyle" Value="true"/>
         <Style.Triggers>
             <Trigger Property="Orientation" Value="Horizontal">

Aronium.Wpf.Toolkit/Themes/SplitButtonStyle.xaml

@@ -15,11 +15,9 @@
                     <ColumnDefinition Width="Auto" />
                 </Grid.ColumnDefinitions>
 
-                <!--Buttons in grid do not fit the layout, for that reason margin right is set to -1 and -0.5, to fit full area-->
-
-                <Button Name="PART_Button" BorderThickness="0" Margin="0,0,-1,0" Padding="{TemplateBinding Padding}" Content="{TemplateBinding Content}"/>
+                <Button Name="PART_Button" BorderThickness="0" Margin="0,0,0,0" Padding="{TemplateBinding Padding}" Content="{TemplateBinding Content}"/>
                 <Rectangle Margin="0" Fill="{TemplateBinding BorderBrush}" Width="1" Grid.Column="1" />
-                <ToggleButton Name="PART_DropDownButton" Margin="0,0,-0.5,0" Padding="5,0" VerticalContentAlignment="Center" BorderThickness="0" Grid.Column="2">
+                <ToggleButton Name="PART_DropDownButton" Margin="0,0,0,0" Padding="5,0" VerticalContentAlignment="Center" BorderThickness="0" Grid.Column="2">
                     <Path Fill="{Binding ElementName=PART_DropDownButton, Path=Foreground}" 
                                       x:Name="Arrow" 
                                       SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" 

Aronium.Wpf.Toolkit/Themes/TabControlStyle.xaml

@@ -6,7 +6,6 @@
     <Style TargetType="{x:Type TabItem}">
         <Setter Property="Background" Value="{DynamicResource BackgroundBrush}" />
         <Setter Property="Foreground" Value="{DynamicResource Foreground}" />
-        <Setter Property="SnapsToDevicePixels" Value="True" />
         <Setter Property="FontSize" Value="13" />
         <Setter Property="Padding" Value="13,4" />
         <Setter Property="Template">
@@ -72,8 +71,6 @@
                             <Setter TargetName="arrow" Property="VerticalAlignment" Value="Center" />
                             <Setter TargetName="arrow" Property="Margin" Value="-5,0.5,0,0" />
                             <Setter TargetName="ContentSite" Property="HorizontalAlignment" Value="Right" />
-                            <!--When turned on, for some reason, arrow is not positioned properly-->
-                            <Setter Property="UseLayoutRounding" Value="False" />
                         </Trigger>
 
                         <Trigger Property="TabItem.TabStripPlacement" Value="Bottom">
@@ -210,8 +207,6 @@
         <Setter Property="Foreground" Value="{DynamicResource Foreground}" />
         <Setter Property="BorderBrush" Value="{DynamicResource Accent}" />
         <Setter Property="OverridesDefaultStyle" Value="True" />
-        <!-- If UseLayoutRounding is turned off, arrow with left layout is not positioned propely -->
-        <Setter Property="UseLayoutRounding" Value="True" />
         <Style.Triggers>
             <Trigger Property="TabStripPlacement" Value="Top">
                 <Setter Property="Template" Value="{StaticResource TabControlTemplate}" />
@@ -259,7 +254,6 @@
         <Setter Property="Background" Value="Transparent" />
         <Setter Property="BorderBrush" Value="Transparent" />
         <Setter Property="Foreground" Value="{DynamicResource Foreground}" />
-        <Setter Property="SnapsToDevicePixels" Value="True" />
         <Setter Property="FontSize" Value="13" />
         <Setter Property="Padding" Value="14,7" />
         <Setter Property="Template">
@@ -329,6 +323,7 @@
         <Setter Property="Template" Value="{StaticResource MaterialTabControlTemplate}" />
         <Setter Property="HorizontalContentAlignment" Value="Left" />
         <Setter Property="ItemContainerStyle" Value="{StaticResource MaterialTabItemStyle}" />
+        <Setter Property="SnapsToDevicePixels" Value="True" />
     </Style>
 
 </ResourceDictionary>

Aronium.Wpf.Toolkit/Themes/ToggleSwitchStyle.xaml

@@ -110,7 +110,6 @@
 
     <Style TargetType="{x:Type local:ToggleSwitch}">
         <Setter Property="IsThreeState" Value="False" />
-        <Setter Property="SnapsToDevicePixels" Value="True" />
         <Setter Property="Background" Value="{DynamicResource OnOffButtonSliderBackground}" />
         <Setter Property="BackgroundChecked" Value="{DynamicResource OnOffButtonSliderBackgroundChecked}" />
         <Setter Property="BorderBrushChecked" Value="{DynamicResource OnOffButtonBorderBrushCheked}" />