co-existence with cordova-plugin-local-notification on iOS #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local notifications on iOS via cordova-plugin-local-notification are working again. Click-callback for remote notifications not working right now. Details: UNUserNotificationCenter accepts a single delegate that handles the display of notifications. cordova-plugin-firebase now stores a reference to the existing delegate if any and proxies the delegate-calls (cordova-plugin-local-notification is already doing that in the other direction when applicable).
Click-callback for remote notifications are working again. Both cordova-plugin-firebase and cordova-plugin-local-notification seem to be working fine now. Not tested yet: - local notifications that are not immediately triggered while the app is in foreground (e.g. trigger at location or date)
soumak77
approved these changes
May 10, 2018
This was referenced May 10, 2018
Closed
|
I just installed the cordova-plugin-local-notification plugin but I still have an problem with receiving the messages in the OnNotificationOpen callback. I have the firebase plugin with this fix. Is there something else I have to do? |
|
Im having the same issue as dmeij, using the latest firebase and local-notification plugins. EDIT: |
jkronborg
added a commit
to moveleft/cordova-plugin-fcm-with-dependecy-updated
that referenced
this pull request
Apr 4, 2019
With this change the plugin works together with cordova-plugin-local-notifications. Based on arnesson/cordova-plugin-firebase#680.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local notifications on iOS via cordova-plugin-local-notification were not working.
UNUserNotificationCenter accepts a single delegate that handles the display of notifications. cordova-plugin-firebase now stores a reference to the existing delegate if any and proxies the delegate-calls (cordova-plugin-local-notification is already doing that in the other direction when applicable).
This is basically just undoing some changes made in #576