Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional requirements? #4

Open
joelnmdyer opened this issue Jun 15, 2023 · 2 comments
Open

Add additional requirements? #4

joelnmdyer opened this issue Jun 15, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@joelnmdyer
Copy link
Collaborator

joelnmdyer commented Jun 15, 2023 •
edited
Loading

Perhaps I did something wrong, but currently I had to pip install

  • jupyter
  • matplotlib
  • pandas
  • pygtc
  • corner

separately to run example notebooks, after running pip install -e ./ in the root directory of repo. So maybe include in requirements.txt?
@joelnmdyer joelnmdyer added the documentation Improvements or additions to documentation label Jun 15, 2023
@joelnmdyer joelnmdyer changed the title Add jupyter to requirements? Add additional requirements? Jun 15, 2023
@arnauqb
Copy link
Owner

arnauqb commented Jun 15, 2023

IMO this could be listed as additional requirements in the examples folder, but the package itself does not depend on them strictly (as in no function inside the birds folder uses any of those libraries).

@joelnmdyer
Copy link
Collaborator Author

Yeah, I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arnauqb @joelnmdyer