You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix cmake syntax in generate_version_txt.cmake. (#96)
Commit 23f1d75 included `$(LLVM_TOOLCHAIN_C_LIBRARY)`, which
isn't valid cmake syntax – to interpolate a cmake variable you have to
use braces, not parentheses.
This led to a mysterious error from git
fatal: cannot change to 'rev-parse': No such file or directory
because once `${base_library}` is set to something that doesn't make
sense, `git -C ${${base_library}_SOURCE_DIR} rev-parse HEAD` substitutes
nothing at all for the source directory, and the command collapses to
just `git -C rev-parse` which indeed interprets `rev-parse` as the
directory to change into.
0 commit comments