Tests: use strict assertions (sirbrillig#247)

jrfnl · web-flow · commit 562e47cbbaf5 · 2022-05-26T17:40:21.000-04:00
`assertEquals()` comes down to a loose type `==` comparison, while `assertSame()` does a strict type `===` comparison, so if at all possible, one should always use `assertSame()` instead of `assertEquals()`.

Co-authored-by: jrfnl &lt;jrfnl@users.noreply.github.com&gt;
diff --git a/Tests/VariableAnalysisSniff/ArrayAssignmentShortcutTest.php b/Tests/VariableAnalysisSniff/ArrayAssignmentShortcutTest.php
@@ -16,7 +16,7 @@ public function testArrayAssignmentReportsCorrectLines() {
       28,
       29,
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 
   public function testArrayAssignmentHasCorrectSniffCodes() {
@@ -25,9 +25,9 @@ public function testArrayAssignmentHasCorrectSniffCodes() {
     $phpcsFile->process();
 
     $warnings = $phpcsFile->getWarnings();
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable', $warnings[21][5][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable', $warnings[27][5][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[28][5][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable', $warnings[29][10][0]['source']);
+    $this->assertSame('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable', $warnings[21][5][0]['source']);
+    $this->assertSame('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable', $warnings[27][5][0]['source']);
+    $this->assertSame('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[28][5][0]['source']);
+    $this->assertSame('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable', $warnings[29][10][0]['source']);
   }
 }
diff --git a/Tests/VariableAnalysisSniff/ArrowFunctionTest.php b/Tests/VariableAnalysisSniff/ArrowFunctionTest.php
@@ -27,7 +27,7 @@ public function testArrowFunctions() {
       67,
       71,
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 
   public function testArrowFunctionsWithoutUnusedBeforeUsed() {
@@ -55,6 +55,6 @@ public function testArrowFunctionsWithoutUnusedBeforeUsed() {
       67,
       71,
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 }
diff --git a/Tests/VariableAnalysisSniff/ClosingPhpTagsTest.php b/Tests/VariableAnalysisSniff/ClosingPhpTagsTest.php
@@ -15,17 +15,17 @@ public function testVariableWarningsWhenClosingTagsAreUsed() {
       13,
       16,
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 
   public function testVariableWarningsHaveCorrectSniffCodesWhenClosingTagsAreUsed() {
     $fixtureFile = $this->getFixture('ClosingPhpTagsFixture.php');
     $phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);
     $phpcsFile->process();
     $warnings = $phpcsFile->getWarnings();
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[6][1][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable', $warnings[8][6][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[13][1][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable', $warnings[16][6][0]['source']);
+    $this->assertSame('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[6][1][0]['source']);
+    $this->assertSame('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable', $warnings[8][6][0]['source']);
+    $this->assertSame('VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable', $warnings[13][1][0]['source']);
+    $this->assertSame('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable', $warnings[16][6][0]['source']);
   }
 }
diff --git a/Tests/VariableAnalysisSniff/GlobalScopeTest.php b/Tests/VariableAnalysisSniff/GlobalScopeTest.php
@@ -20,7 +20,7 @@ public function testGlobalScopeWarnings() {
       10,
       13,
     ];
-    $this->assertEquals($expectedErrors, $lines);
+    $this->assertSame($expectedErrors, $lines);
   }
 
   public function testGlobalScopeWarningsWithAllowUndefinedVariablesInFileScope() {
@@ -38,7 +38,7 @@ public function testGlobalScopeWarningsWithAllowUndefinedVariablesInFileScope()
       10,
       13,
     ];
-    $this->assertEquals($expectedErrors, $lines);
+    $this->assertSame($expectedErrors, $lines);
   }
 
   public function testGlobalScopeWarningsWithAllowUnusedVariablesInFileScope() {
@@ -55,6 +55,6 @@ public function testGlobalScopeWarningsWithAllowUnusedVariablesInFileScope() {
       7,
       10,
     ];
-    $this->assertEquals($expectedErrors, $lines);
+    $this->assertSame($expectedErrors, $lines);
   }
 }
diff --git a/Tests/VariableAnalysisSniff/IfConditionTest.php b/Tests/VariableAnalysisSniff/IfConditionTest.php
@@ -33,7 +33,7 @@ public function testIfConditionWarnings() {
       176,
       179,
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 
   public function testIfConditionWarningsWithValidUndefinedVariableNames() {
@@ -64,7 +64,7 @@ public function testIfConditionWarningsWithValidUndefinedVariableNames() {
       176,
       179,
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 
   public function testInlineIfConditionWarnings() {
@@ -96,7 +96,7 @@ public function testInlineIfConditionWarnings() {
       152,
       154,
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 
   public function testInlineIfConditionWarningsWithValidUndefinedVariableNames() {
@@ -127,6 +127,6 @@ public function testInlineIfConditionWarningsWithValidUndefinedVariableNames() {
       152,
       154,
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 }
diff --git a/Tests/VariableAnalysisSniff/IssetTest.php b/Tests/VariableAnalysisSniff/IssetTest.php
@@ -13,6 +13,6 @@ public function testIssetVariableUse() {
       4,
       23, // ideally this should not be a warning, but will be because it is difficult to know: https://github.com/sirbrillig/phpcs-variable-analysis/issues/202#issuecomment-688507314
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 }
diff --git a/Tests/VariableAnalysisSniff/UnsetTest.php b/Tests/VariableAnalysisSniff/UnsetTest.php
@@ -14,7 +14,7 @@ public function testUnsetReportsUndefinedVariables() {
       6,
       11,
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 
   public function testUnsetHasCorrectSniffCodes() {
@@ -23,7 +23,7 @@ public function testUnsetHasCorrectSniffCodes() {
     $phpcsFile->process();
 
     $warnings = $phpcsFile->getWarnings();
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedUnsetVariable', $warnings[6][7][0]['source']);
-    $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedUnsetVariable', $warnings[11][9][0]['source']);
+    $this->assertSame('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedUnsetVariable', $warnings[6][7][0]['source']);
+    $this->assertSame('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedUnsetVariable', $warnings[11][9][0]['source']);
   }
 }
diff --git a/Tests/VariableAnalysisSniff/UnusedFollowedByRequireTest.php b/Tests/VariableAnalysisSniff/UnusedFollowedByRequireTest.php
@@ -23,7 +23,7 @@ public function testUnusedFollowedByRequireWarnsByDefault() {
       21,
       22,
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 
   public function testUnusedFollowedByRequireDoesNotWarnWhenSet() {
@@ -42,7 +42,7 @@ public function testUnusedFollowedByRequireDoesNotWarnWhenSet() {
       16,
       22,
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 
   public function testUnusedFollowedByRequireDoesNotBreakOtherThingsWhenSet() {
@@ -69,6 +69,6 @@ public function testUnusedFollowedByRequireDoesNotBreakOtherThingsWhenSet() {
       18,
       19,
     ];
-    $this->assertEquals($expectedWarnings, $lines);
+    $this->assertSame($expectedWarnings, $lines);
   }
 }
diff --git a/Tests/VariableAnalysisSniff/VariableAnalysisTest.php b/Tests/VariableAnalysisSniff/VariableAnalysisTest.php
diff --git a/Tests/VariableAnalysisSniff/VariableArgumentListTest.php b/Tests/VariableAnalysisSniff/VariableArgumentListTest.php
diff --git a/Tests/VariableAnalysisSniff/WhileLoopTest.php b/Tests/VariableAnalysisSniff/WhileLoopTest.php

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public function testArrowFunctions() {`
`27`	`27`	`67,`
`28`	`28`	`71,`
`29`	`29`	`];`
`30`		`- $this->assertEquals($expectedWarnings, $lines);`
	`30`	`+ $this->assertSame($expectedWarnings, $lines);`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`public function testArrowFunctionsWithoutUnusedBeforeUsed() {`
`@@ -55,6 +55,6 @@ public function testArrowFunctionsWithoutUnusedBeforeUsed() {`
`55`	`55`	`67,`
`56`	`56`	`71,`
`57`	`57`	`];`
`58`		`- $this->assertEquals($expectedWarnings, $lines);`
	`58`	`+ $this->assertSame($expectedWarnings, $lines);`
`59`	`59`	`}`
`60`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public function testGlobalScopeWarnings() {`
`20`	`20`	`10,`
`21`	`21`	`13,`
`22`	`22`	`];`
`23`		`- $this->assertEquals($expectedErrors, $lines);`
	`23`	`+ $this->assertSame($expectedErrors, $lines);`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`public function testGlobalScopeWarningsWithAllowUndefinedVariablesInFileScope() {`
`@@ -38,7 +38,7 @@ public function testGlobalScopeWarningsWithAllowUndefinedVariablesInFileScope()`
`38`	`38`	`10,`
`39`	`39`	`13,`
`40`	`40`	`];`
`41`		`- $this->assertEquals($expectedErrors, $lines);`
	`41`	`+ $this->assertSame($expectedErrors, $lines);`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`public function testGlobalScopeWarningsWithAllowUnusedVariablesInFileScope() {`
`@@ -55,6 +55,6 @@ public function testGlobalScopeWarningsWithAllowUnusedVariablesInFileScope() {`
`55`	`55`	`7,`
`56`	`56`	`10,`
`57`	`57`	`];`
`58`		`- $this->assertEquals($expectedErrors, $lines);`
	`58`	`+ $this->assertSame($expectedErrors, $lines);`
`59`	`59`	`}`
`60`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public function testIfConditionWarnings() {`
`33`	`33`	`176,`
`34`	`34`	`179,`
`35`	`35`	`];`
`36`		`- $this->assertEquals($expectedWarnings, $lines);`
	`36`	`+ $this->assertSame($expectedWarnings, $lines);`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`public function testIfConditionWarningsWithValidUndefinedVariableNames() {`
`@@ -64,7 +64,7 @@ public function testIfConditionWarningsWithValidUndefinedVariableNames() {`
`64`	`64`	`176,`
`65`	`65`	`179,`
`66`	`66`	`];`
`67`		`- $this->assertEquals($expectedWarnings, $lines);`
	`67`	`+ $this->assertSame($expectedWarnings, $lines);`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`public function testInlineIfConditionWarnings() {`
`@@ -96,7 +96,7 @@ public function testInlineIfConditionWarnings() {`
`96`	`96`	`152,`
`97`	`97`	`154,`
`98`	`98`	`];`
`99`		`- $this->assertEquals($expectedWarnings, $lines);`
	`99`	`+ $this->assertSame($expectedWarnings, $lines);`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`public function testInlineIfConditionWarningsWithValidUndefinedVariableNames() {`
`@@ -127,6 +127,6 @@ public function testInlineIfConditionWarningsWithValidUndefinedVariableNames() {`
`127`	`127`	`152,`
`128`	`128`	`154,`
`129`	`129`	`];`
`130`		`- $this->assertEquals($expectedWarnings, $lines);`
	`130`	`+ $this->assertSame($expectedWarnings, $lines);`
`131`	`131`	`}`
`132`	`132`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,6 @@ public function testIssetVariableUse() {`
`13`	`13`	`4,`
`14`	`14`	`23, // ideally this should not be a warning, but will be because it is difficult to know: https://github.com/sirbrillig/phpcs-variable-analysis/issues/202#issuecomment-688507314`
`15`	`15`	`];`
`16`		`- $this->assertEquals($expectedWarnings, $lines);`
	`16`	`+ $this->assertSame($expectedWarnings, $lines);`
`17`	`17`	`}`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ public function testUnsetReportsUndefinedVariables() {`
`14`	`14`	`6,`
`15`	`15`	`11,`
`16`	`16`	`];`
`17`		`- $this->assertEquals($expectedWarnings, $lines);`
	`17`	`+ $this->assertSame($expectedWarnings, $lines);`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`public function testUnsetHasCorrectSniffCodes() {`
`@@ -23,7 +23,7 @@ public function testUnsetHasCorrectSniffCodes() {`
`23`	`23`	`$phpcsFile->process();`
`24`	`24`
`25`	`25`	`$warnings = $phpcsFile->getWarnings();`
`26`		`- $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedUnsetVariable', $warnings[6][7][0]['source']);`
`27`		`- $this->assertEquals('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedUnsetVariable', $warnings[11][9][0]['source']);`
	`26`	`+ $this->assertSame('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedUnsetVariable', $warnings[6][7][0]['source']);`
	`27`	`+ $this->assertSame('VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedUnsetVariable', $warnings[11][9][0]['source']);`
`28`	`28`	`}`
`29`	`29`	`}`