Skip to content

Commit 0c25aa9

Browse files
authored
PHPUnit: update configuration (sirbrillig#241)
PHPUnit just released version 9.5.10 and 8.5.21. This contains a particular (IMO breaking) change: > * PHPUnit no longer converts PHP deprecations to exceptions by default (configure `convertDeprecationsToExceptions="true"` to enable this) Let's unpack this: Previously (PHPUnit < 9.5.10/8.5.21), if PHPUnit would encounter a PHP native deprecation notice, it would: 1. Show a test which causes a deprecation notice to be thrown as **"errored"**, 2. Show the **first** deprecation notice it encountered and 3. PHPUnit would exit with a **non-0 exit code** (2), which will fail a CI build. As of PHPUnit 9.5.10/8.5.21, if PHPUnit encounters a PHP native deprecation notice, it will no longer do so. Instead PHPUnit will: 1. Show a test which causes a PHP deprecation notice to be thrown as **"risky"**, 2. Show the **all** deprecation notices it encountered and 3. PHPUnit will exit with a **0 exit code**, which will show a CI build as passing. This commit reverts PHPUnit to the previous behaviour by adding `convertDeprecationsToExceptions="true"` to the PHPUnit configuration. It also adds the other related directives for consistency. Refs: * https://github.com/sebastianbergmann/phpunit/blob/9.5/ChangeLog-8.5.md * https://github.com/sebastianbergmann/phpunit/blob/9.5/ChangeLog-9.5.md Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
1 parent 3fad284 commit 0c25aa9

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

phpunit.circleci.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
<phpunit
22
bootstrap="Tests/bootstrap.php"
3+
convertErrorsToExceptions="true"
4+
convertWarningsToExceptions="true"
5+
convertNoticesToExceptions="true"
6+
convertDeprecationsToExceptions="true"
37
>
48
<testsuites>
59
<testsuite name="VariableAnalysis">

phpunit.xml.dist

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
<phpunit
22
bootstrap="Tests/bootstrap.php"
33
printerClass="LimeDeck\Testing\Printer"
4+
convertErrorsToExceptions="true"
5+
convertWarningsToExceptions="true"
6+
convertNoticesToExceptions="true"
7+
convertDeprecationsToExceptions="true"
48
>
59
<testsuites>
610
<testsuite name="VariableAnalysis">

0 commit comments

Comments
 (0)