Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postcss-preset-env v9.x.x #347

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

romainmenke
Copy link
Contributor

@romainmenke romainmenke commented Feb 11, 2023

supersedes : #234

unminified diff can be viewed here : romainmenke@ed93c5e

@stackblitz
Copy link

stackblitz bot commented Feb 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@argyleink
Copy link
Owner

thanks for this kick start! i just spent 5m reviewing the diff and running some stuff locally. will need to set aside a chunk of time for this task.

@argyleink
Copy link
Owner

is postcss-combine-duplicated-selectors still misbehaving? i agree it's normally not advised, but for the bundling of props it's great.

@romainmenke
Copy link
Contributor Author

is postcss-combine-duplicated-selectors still misbehaving? i agree it's normally not advised, but for the bundling of props it's great.

yup, maybe better to create a dedicated plugin that does exactly what you need it to do for open-props?

@argyleink
Copy link
Owner

is postcss-combine-duplicated-selectors still misbehaving? i agree it's normally not advised, but for the bundling of props it's great.

yup, maybe better to create a dedicated plugin that does exactly what you need it to do for open-props?

merged!

@romainmenke
Copy link
Contributor Author

nice!

A lot has happened since originally opening this pull request and I noticed that we removed a feature somewhere along the way that you depend on here. Transpiling of media range syntax in @custom-media is no longer supported. But I think we should bring this back.

I will modernise this pull request after patching that issue.

@romainmenke romainmenke changed the title postcss-preset-env v8.0.1 postcss-preset-env v9.x.x Sep 25, 2023
@romainmenke
Copy link
Contributor Author

romainmenke commented Sep 25, 2023

@argyleink This is ready for another look.
I've updated the diff preview in the original post at the top, but another link here : romainmenke@ed93c5e

Summary :

  • some white space is different (should largely go away when minifying which I disabled for the preview)
  • ; are now added by the nesting plugin, this fixed some issues for some users
  • nesting plugins works slightly differently which seems to result in fewer useless/empty rules
  • media range syntax plugin now emits px fractions
  • order of selector bits in a single compound selector can be different but this will never have a different outcome
  • :has() polyfill is now disabled

@argyleink
Copy link
Owner

I added this back in to postcss.config.cjs to remove the .focus-visible or .focus-within conveniences, and then disabled :has() so it just passes through.

'has-pseudo-class': false,
'focus-visible-pseudo-class': false,
'focus-within-pseudo-class': false,

pending I do a deeper comparison, this PR is lookin good.

I also need to update the docsite in /docsite. Will test out these updates there too and get back to this PR with findings.

Thanks Romain!

@romainmenke
Copy link
Contributor Author

Definitely fine to disable those explicitly but this isn't needed anymore as of version 8.
Any plugin that also requires some client-side JS script is now disabled by default.

We found that too many users had these plugins enabled without knowing this and without loading the client-side JS scripts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants