Remove EOF: Replace std::vector<CodeSection> evmasm:: Assembly::m_codeSections with AssemblyItems.#16757
Open
rodiazet wants to merge 1 commit into
Open
Remove EOF: Replace std::vector<CodeSection> evmasm:: Assembly::m_codeSections with AssemblyItems.#16757rodiazet wants to merge 1 commit into
std::vector<CodeSection> evmasm:: Assembly::m_codeSections with AssemblyItems.#16757rodiazet wants to merge 1 commit into
Conversation
Since EOF is removed there is only ever one code section. Replace m_codeSections (vector) and m_currentCodeSection with an m_items member and rename the accessor from codeSections() to items(). Also remove the now-unused inputs/outputs/ nonReturning fields from the CodeSection struct.
rodiazet
added
the
has dependencies
rodiazet
changed the title
std::vector<CodeSection> evmasm:: Assembly::m_codeSections with AssemblyItems.std::vector<CodeSection> evmasm:: Assembly::m_codeSections with AssemblyItems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without EOF we have only one code section. No need to support code sections any more.
Partially made by Claude Sonnet 4.6
Depends on #16584