-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Update metadata docs for "libraries" and "compilationSettings" fields #15895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, but there's actually even more we could add. See my suggestions below.
a5fc6f8 to
7654626
Compare
|
Rebased and updated. Now the settings only has "compilationTarget" and "libraries", and refers the rest to the std-json docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs some corrections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good now. Thanks for taking the time to improve this part of the docs :)
|
Oh, one more thing before we merge. Can you squash the commits a bit? Does not have to be one, but we generally at least squash the fixes from review into the original commits to keep history easier to understand. |
dbf7155 to
dbc7a49
Compare
|
Rebased |
dbc7a49 to
2565ee4
Compare
2565ee4 to
1f044c1
Compare
No description provided.