Skip to content

Conversation

@kuzdogan
Copy link
Member

No description provided.

@github-actions
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, but there's actually even more we could add. See my suggestions below.

@kuzdogan kuzdogan force-pushed the update-metadata-docs branch from a5fc6f8 to 7654626 Compare March 13, 2025 07:47
@kuzdogan
Copy link
Member Author

Rebased and updated. Now the settings only has "compilationTarget" and "libraries", and refers the rest to the std-json docs.

Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs some corrections.

Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good now. Thanks for taking the time to improve this part of the docs :)

@cameel
Copy link
Collaborator

cameel commented Mar 20, 2025

Oh, one more thing before we merge. Can you squash the commits a bit? Does not have to be one, but we generally at least squash the fixes from review into the original commits to keep history easier to understand.

@kuzdogan kuzdogan force-pushed the update-metadata-docs branch from dbf7155 to dbc7a49 Compare March 21, 2025 10:41
@kuzdogan
Copy link
Member Author

Rebased

@kuzdogan kuzdogan force-pushed the update-metadata-docs branch from dbc7a49 to 2565ee4 Compare March 21, 2025 10:42
@cameel cameel force-pushed the update-metadata-docs branch from 2565ee4 to 1f044c1 Compare March 21, 2025 17:05
@cameel cameel enabled auto-merge March 21, 2025 17:05
@cameel cameel merged commit cc58ab1 into argotorg:develop Mar 21, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants