-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Calldata validation tests #13289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calldata validation tests #13289
Conversation
|
Any reason for not adding |
@ekpyron The reason is an error message that keeps changing in consecutive test runs. An example:
I guess we may want to fix that, but I am not sure if we should do that in scope of this ticket. |
|
Ah right, I vaguely remember that there's some legacy vs. via-IR differences with some of these cases - we should indeed try to fix that and align those eventually, but true, no need to burden this PR with that. |
| } | ||
|
|
||
| function f_which(uint[] calldata a, uint[2] calldata b, uint which) public returns (bytes memory) { | ||
| return abi.encode(a[which], b[1]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation, also below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A fixup commit delivered. Also, I delivered another one that removes compileViaYul: also option, because meanwhile it became a default.
c9947e9 to
60e7e4a
Compare
closes #12922