Update ir-breaking-changes and make it visible. #12258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
irbreakingchangesvisible
branch
from
10b4c7f to
ff1fb60
Compare
bshastry
reviewed
Nov 8, 2021
Contributor
bshastry
left a comment
bshastry
left a comment
There was a problem hiding this comment.
LGTM. Is there a way to preview the web page to spot formatting errors?
Contributor
Author
|
Yes, go to the artifacts of the |
bshastry
previously approved these changes
Nov 8, 2021
Contributor
|
Layout and text look good to me. Approving. |
ekpyron
previously approved these changes
Nov 8, 2021
Collaborator
ekpyron
left a comment
ekpyron
left a comment
There was a problem hiding this comment.
I haven't checked for exhaustiveness of the docs, but the changes look good!
cameel
previously approved these changes
Nov 8, 2021
Collaborator
cameel
left a comment
cameel
left a comment
There was a problem hiding this comment.
I also haven't re-read the whole doc but the changes visible in the diff look reasonable.
chriseth
force-pushed
the
irbreakingchangesvisible
branch
from
227bb04 to
df85d26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.