Keep gas values as a string in CompilerStack::gasEstimate

Author: axic

libsolidity/interface/CompilerStack.cpp

@@ -847,10 +847,10 @@ namespace {
 
 Json::Value gasToJson(GasEstimator::GasConsumption const& _gas)
 {
-    if (_gas.isInfinite || _gas.value > std::numeric_limits<Json::LargestUInt>::max())
-	return Json::Value(Json::nullValue);
+    if (_gas.isInfinite)
+	return Json::Value("infinite");
     else
-	return Json::Value(Json::LargestUInt(_gas.value));
+	return Json::Value(toString(_gas.value));
 }
 
 }

solc/CommandLineInterface.cpp

@@ -322,18 +322,18 @@ void CommandLineInterface::handleGasEstimation(string const& _contract)
 	{
 		Json::Value creation = estimates["creation"];
 		cout << "construction:" << endl;
-		if (creation["executionCost"].isNull())
+		if (creation["executionCost"] == "infinite")
 			cout << "   infinite";
 		else
-			cout << "   " << creation["executionCost"];
-		if (creation["codeDepositCost"].isNull())
+			cout << "   " << u256(creation["executionCost"].asString());
+		if (creation["codeDepositCost"] == "infinite")
 			cout << " + infinite";
 		else
-			cout << " + " << creation["codeDepositCost"];
-		if (creation["totalCost"].isNull())
+			cout << " + " << u256(creation["codeDepositCost"].asString());
+		if (creation["totalCost"] == "infinite")
 			cout << " = infinite";
 		else
-			cout << " = " << creation["totalCost"] << endl;
+			cout << " = " << u256(creation["totalCost"].asString()) << endl;
 	}
 
 	if (estimates["external"].isObject())
@@ -346,10 +346,10 @@ void CommandLineInterface::handleGasEstimation(string const& _contract)
 				cout << "   fallback:\t";
 			else
 				cout << "   " << name << ":\t";
-			if (externalFunctions[name].isNull())
+			if (externalFunctions[name] == "infinite")
 				cout << "infinite" << endl;
 			else
-				cout << externalFunctions[name] << endl;
+				cout << u256(externalFunctions[name].asString()) << endl;
 		}
 	}
 
@@ -360,10 +360,10 @@ void CommandLineInterface::handleGasEstimation(string const& _contract)
 		for (auto const& name: internalFunctions.getMemberNames())
 		{
 			cout << "   " << name << ":\t";
-			if (internalFunctions[name].isNull())
+			if (internalFunctions[name] == "infinite")
 				cout << "infinite" << endl;
 			else
-				cout << internalFunctions[name] << endl;
+				cout << u256(internalFunctions[name].asString()) << endl;
 		}
 	}
 }

solc/jsonCompiler.cpp

@@ -58,6 +58,27 @@ Json::Value functionHashes(ContractDefinition const& _contract)
 	return functionHashes;
 }
 
+/// Translates a gas value as a string to a JSON number or null
+Json::Value gasToJson(Json::Value const& _value)
+{
+	if (_value.isObject())
+	{
+		Json::Value ret = Json::objectValue;
+		for (auto const& sig: _value.getMemberNames())
+			ret[sig] = gasToJson(_value[sig]);
+		return ret;
+	}
+
+	if (_value == "infinite")
+		return Json::Value(Json::nullValue);
+
+	u256 value(_value.asString());
+	if (value > std::numeric_limits<Json::LargestUInt>::max())
+		return Json::Value(Json::nullValue);
+	else
+		return Json::Value(Json::LargestUInt(value));
+}
+
 Json::Value estimateGas(CompilerStack const& _compiler, string const& _contract)
 {
 	Json::Value estimates = _compiler.gasEstimates(_contract);
@@ -66,14 +87,14 @@ Json::Value estimateGas(CompilerStack const& _compiler, string const& _contract)
 	if (estimates["creation"].isObject())
 	{
 		Json::Value creation(Json::arrayValue);
-		creation[0] = estimates["creation"]["executionCost"];
-		creation[1] = estimates["creation"]["codeDepositCost"];
+		creation[0] = gasToJson(estimates["creation"]["executionCost"]);
+		creation[1] = gasToJson(estimates["creation"]["codeDepositCost"]);
 		output["creation"] = creation;
 	}
 	else
 		output["creation"] = Json::objectValue;
-	output["external"] = estimates.get("external", Json::objectValue);
-	output["internal"] = estimates.get("internal", Json::objectValue);
+	output["external"] = gasToJson(estimates.get("external", Json::objectValue));
+	output["internal"] = gasToJson(estimates.get("internal", Json::objectValue));
 
 	return output;
 }