Skip to content

Commit 326b814

Browse files
committed
Disable git's automatic line ending conversion in Windows CI jobs
1 parent 3793cac commit 326b814

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

.circleci/config.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -844,6 +844,7 @@ jobs:
844844
name: win/default
845845
shell: powershell.exe
846846
steps:
847+
# NOTE: Not disabling git's core.autocrlf here because we want to build using the typical Windows config.
847848
- checkout
848849
- restore_cache:
849850
keys:
@@ -880,6 +881,8 @@ jobs:
880881
name: win/default
881882
shell: powershell.exe
882883
steps:
884+
# NOTE: Git's default core.autocrlf is fine for running soltest. We get additional coverage
885+
# for files using CRLF that way.
883886
- checkout
884887
- attach_workspace:
885888
at: build
@@ -932,6 +935,9 @@ jobs:
932935
name: win/default
933936
shell: cmd.exe
934937
steps:
938+
# NOTE: For bytecode generation we need the input files to be byte-for-byte identical on all
939+
# platforms so line ending conversions must absolutely be disabled.
940+
- run: git config --global core.autocrlf false
935941
- checkout
936942
- attach_workspace:
937943
at: build

0 commit comments

Comments
 (0)