Sort using semver #8
Conversation
|
Haha! Yes, we could use |
update
Outdated
| version += '-' + build.prerelease; | ||
| } | ||
| if (build.build && build.build.length > 0) { | ||
| version += '-' + build.build; |
| fs.readdir(path.join(__dirname, '/bin'), function (err, files) { | ||
| if (err) return err | ||
|
|
||
| function buildVersion (build) { |
There was a problem hiding this comment.
Do we really need to rebuild it again?
There was a problem hiding this comment.
Actually if we rebuild it with MM.DD we don't even need semver to do the comparison.
| .map(function (pars) { console.log(pars[0]); return { path: pars[0], version: pars[1], prerelease: pars[3], build: pars[5] } }) | ||
| .sort(function (a, b) { | ||
| // NOTE: a vs. b (the order is important), because we want oldest first in the list | ||
| return semver.compare(buildVersion(a), buildVersion(b)) |
There was a problem hiding this comment.
We could just use the semver module to also parse the version string.
There was a problem hiding this comment.
True, the only downside having semver is that it must be npm installed before running update.
There was a problem hiding this comment.
Actually semver doesn't seem to return the build part (only versions and prerelease).
|
This works well with #11 (parsedList becomes the sortedList). |
|
@chriseth are we happy adding The Solidity push script I prefer a) for the moment, until we add more dependencies. |
|
Actually I think it is more future proof (less changes in the Solidity repo) if we have a package.json (marked @chriseth added that in that case we could also run |
axic
force-pushed
the
sort
branch
2 times, most recently
from
ee1cb87 to
341f8f3
Compare
Fixes the out of order versions.
However for simplicity we should just move to dates in the form of YYYY.MM.DD (and not YYYY.M.D).