Skip to content

feat(syncwaves): use binary tree ordering for sync waves #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SebastienFelix
Copy link

No description provided.

@SebastienFelix SebastienFelix requested a review from a team as a code owner July 5, 2025 12:34
@SebastienFelix SebastienFelix force-pushed the useBinaryTreeOrderingForSyncWaves branch 3 times, most recently from 8275ab1 to 3718097 Compare July 5, 2025 12:54
Copy link

codecov bot commented Jul 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.63%. Comparing base (8849c3f) to head (cf27063).
Report is 52 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
- Coverage   54.26%   48.63%   -5.64%     
==========================================
  Files          64       64              
  Lines        6164     6718     +554     
==========================================
- Hits         3345     3267      -78     
- Misses       2549     3194     +645     
+ Partials      270      257      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SebastienFelix SebastienFelix force-pushed the useBinaryTreeOrderingForSyncWaves branch 6 times, most recently from 59d4d82 to 2ab1f3f Compare July 5, 2025 15:48
@SebastienFelix SebastienFelix changed the title feat(syncwaves) - use binary tree ordering for sync waves feat(syncwaves): use binary tree ordering for sync waves Jul 5, 2025
Signed-off-by: SebastienFelix <sebastien.felix3@gmail.com>
@SebastienFelix SebastienFelix force-pushed the useBinaryTreeOrderingForSyncWaves branch from 2ab1f3f to cf27063 Compare July 5, 2025 16:43
Copy link

sonarqubecloud bot commented Jul 5, 2025

@alexec
Copy link

alexec commented Jul 6, 2025

Is this trying to address the same issue as #514 ?

@SebastienFelix
Copy link
Author

SebastienFelix commented Jul 6, 2025

@alexec : kind of, I guess!
The main goal of this feature is to avoid wasting time by waiting for non-related resources to be synced before proceeding a given resource.

I thought about defining the dependencies relation graph the way you did it but I thought that managing the circular dependencies would be too complicated.

The way I did it in this PR completely avoid this issue and avoids adding more complexity with another logical layer.

I openned an issue for that here #734

My solution would allow the implementation of the feature described here #3517 by syncing the applications in parallel and avoiding a stuck component of one application blocking all the resources having a greater syncwave value.

As an example from the mentionned issue :
If the infra-prometheus-operator get stuck during deployment, it would only block the deployment of infra-prometheus-alertRules/grafanaDashboard/thanos

Here is the syncwaves values and the induced dependencies related to the issue #3517
image

WDYT?

P.S : after creating this graph, I realize than the syncwave values would be much more human-readable using base 10 instead of base 2 in my graph. Then the graph would look like that :
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants