-
Notifications
You must be signed in to change notification settings - Fork 289
feat(syncwaves): use binary tree ordering for sync waves #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(syncwaves): use binary tree ordering for sync waves #744
Conversation
8275ab1
to
3718097
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
==========================================
- Coverage 54.26% 48.63% -5.64%
==========================================
Files 64 64
Lines 6164 6718 +554
==========================================
- Hits 3345 3267 -78
- Misses 2549 3194 +645
+ Partials 270 257 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
59d4d82
to
2ab1f3f
Compare
Signed-off-by: SebastienFelix <sebastien.felix3@gmail.com>
2ab1f3f
to
cf27063
Compare
|
Is this trying to address the same issue as #514 ? |
@alexec : kind of, I guess! I thought about defining the dependencies relation graph the way you did it but I thought that managing the circular dependencies would be too complicated. The way I did it in this PR completely avoid this issue and avoids adding more complexity with another logical layer. I openned an issue for that here #734 My solution would allow the implementation of the feature described here #3517 by syncing the applications in parallel and avoiding a stuck component of one application blocking all the resources having a greater syncwave value. As an example from the mentionned issue : Here is the syncwaves values and the induced dependencies related to the issue #3517 WDYT? P.S : after creating this graph, I realize than the syncwave values would be much more human-readable using base 10 instead of base 2 in my graph. Then the graph would look like that : |
No description provided.