Do not use --force with --dry-run

[rafal-jan]

Closes #623.

Currently the same value of force parameter is passed when performing dry-run of a resource and actually creating it on the cluster. This causes issues when using Force=true with sync waves.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 53.52%. Comparing base (8849c3f) to head (c349708).
Report is 47 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/utils/kube/resource_ops.go	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
- Coverage   54.26%   53.52%   -0.74%     
==========================================
  Files          64       64              
  Lines        6164     6520     +356     
==========================================
+ Hits         3345     3490     +145     
- Misses       2549     2753     +204     
- Partials      270      277       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[agaudreault]

Replace behavior is controlled by the options submitted to the package https://github.com/kubernetes/kubectl/blob/4d27286e9c49486b259d0e722b10a11dccfeb494/pkg/cmd/replace/replace.go#L253C1-L253C2

GitOps engine code should respect these options. It would seem like force and dryRun options are not properly configured when calling the Replace command.

What should be done is to update the newReplaceOptions to pass to the Run() method. We should set Force to false if DryRun is provided and we know that validate would throw an error. We should also call the validate method and return any error before calling the Run().

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud