Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GoTemplate #9534

Closed
speedfl opened this issue Sep 6, 2022 · 4 comments
Closed

Use GoTemplate #9534

speedfl opened this issue Sep 6, 2022 · 4 comments
Labels
area/templating Templating with `{{...}}` type/feature Feature request

Comments

@speedfl
Copy link

speedfl commented Sep 6, 2022

Summary

In ArgoCd I implemented usage of GoTemplate for ApplicationSet. Purpose is to do the same in workflow

argoproj/argo-cd#10026

Use Cases

It will be useful in all complex case needing advanced templating features.

Work done with expressions is going in this direction.

Here is an example: examples/expression-reusing-verbose-snippets.yaml


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@speedfl speedfl added the type/feature Feature request label Sep 6, 2022
@callmetushar123
Copy link

Hey I would like to work on this issue please assign it to me.

@alexec
Copy link
Contributor

alexec commented Sep 9, 2022

I don't think this is the right direction. Templating in Argo Workflows is hard to use because (a) we use a mixture of technologies and (b) the evaluation point is non-deterministic.

Adding a new technology to the mix will not help.

@alexec
Copy link
Contributor

alexec commented Sep 9, 2022

Adendmum, to fix both (a) and (b) we need to converge on one techonlogy, which is expr and, wherever we might need to evaluate something, allow the user to define the expression and add it. Example is this:

Expression string `json:"expression" protobuf:"bytes,1,opt,name=expression"`

@agilgur5 agilgur5 added the area/templating Templating with `{{...}}` label Aug 18, 2023
@agilgur5
Copy link
Member

Closing this as not planned per above comments. See #9529 et al for expr standardization

@agilgur5 agilgur5 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/templating Templating with `{{...}}` type/feature Feature request
Projects
None yet
Development

No branches or pull requests

4 participants