resume or stop completed workflow should throw exception

[Colstuwjx]

Checklist

• Double-checked my configuration.
• Tested using the latest version.
• Used the Emissary executor.

Summary

What happened/what you expected to happen?

Happened: when I called argo workflow resume and stop api towards a completed workflow, it didn't panic, and if I turn to call it with suspend or retry, it would complains sth like:

workflow must be Failed/Error to retry

timed out waiting for the condition: cannot suspend completed workflows

Expected: we should also throw exception while we resume or stop a completed workflow.

What version are you running?

v3.2.7

Diagnostics

Paste the smallest workflow that reproduces the bug. We must be able to run the workflow.

# Logs from the workflow controller:
kubectl logs -n argo deploy/workflow-controller | grep ${workflow} 

# If the workflow's pods have not been created, you can skip the rest of the diagnostics.

# The workflow's pods that are problematic:
kubectl get pod -o yaml -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

# Logs from in your workflow's wait container, something like:
kubectl logs -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

[alexec]

Do you mean, when you resume/stop a workflow that is complete via the Argo Server API, you get 200 OK.

[Colstuwjx]

Yes, I think we should return error in these two cases, same to retry and suspend.