Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange rendering of executor plugin API reference doc #7615

Closed
dinever opened this issue Jan 23, 2022 · 4 comments · Fixed by #13258
Closed

Strange rendering of executor plugin API reference doc #7615

dinever opened this issue Jan 23, 2022 · 4 comments · Fixed by #13258
Labels
area/docs Incorrect, missing, or mistakes in docs area/plugins area/upstream This is an issue with an upstream dependency, not Argo itself P3 Low priority type/bug

Comments

@dinever
Copy link
Member

dinever commented Jan 23, 2022

Looks like the multi-line comments got rendered in multiple table rows, making the API docs unreadable: https://argoproj.github.io/argo-workflows/executor_swagger/

Screenshot from 2022-01-22 19-46-42

swagger.yml:

properties:
fsType:
description: |-
Filesystem type of the volume that you want to mount.
Tip: Ensure that the filesystem type is supported by the host operating system.
Examples: "ext4", "xfs", "ntfs". Implicitly inferred to be "ext4" if unspecified.
More info: https://kubernetes.io/docs/concepts/storage/volumes#awselasticblockstore
TODO: how do we prevent errors in the filesystem from compromising the machine
+optional

executor_swagger.md:

| Name | Type | Go type | Required | Default | Description | Example |
|------|------|---------|:--------:| ------- |-------------|---------|
| fsType | string| `string` | | | Filesystem type of the volume that you want to mount.
Tip: Ensure that the filesystem type is supported by the host operating system.
Examples: "ext4", "xfs", "ntfs". Implicitly inferred to be "ext4" if unspecified.
More info: https://kubernetes.io/docs/concepts/storage/volumes#awselasticblockstore
TODO: how do we prevent errors in the filesystem from compromising the machine
+optional | |
| partition | int32 (formatted integer)| `int32` | | | The partition in the volume that you want to mount.

Not sure what's the best workaround for this.

Maybe instead of populating the entire Workflow spec on this page, we could just link to the Field Reference page? https://argoproj.github.io/argo-workflows/fields/

@alexec
Copy link
Contributor

alexec commented Jan 24, 2022

This must be a bug when running env SWAGGER_GENERATE_EXTENSION=false swagger generate markdown -f swagger.yml --output ../../../docs/executor_swagger.md

@stale

This comment was marked as resolved.

@stale stale bot added the problem/stale This has not had a response in some time label Mar 2, 2022
@stale stale bot closed this as completed Apr 16, 2022
@agilgur5 agilgur5 added the P3 Low priority label Oct 20, 2023
@agilgur5 agilgur5 reopened this Oct 20, 2023
@agilgur5 agilgur5 removed the problem/stale This has not had a response in some time label Oct 20, 2023
@tczhao
Copy link
Member

tczhao commented Apr 13, 2024

When go-swagger/go-swagger@36e5a26 release,
it should resolve this issue

@agilgur5
Copy link
Member

agilgur5 commented Apr 13, 2024

go-swagger/go-swagger@36e5a26

For backlinking, go-swagger/go-swagger#3044 is the PR, which closed the upstream issue that Alex filed: go-swagger/go-swagger#2700

But yea go-swagger has needed a new release for a bit: go-swagger/go-swagger#3070

@agilgur5 agilgur5 added the area/upstream This is an issue with an upstream dependency, not Argo itself label Apr 13, 2024
@agilgur5 agilgur5 linked a pull request Jul 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs area/plugins area/upstream This is an issue with an upstream dependency, not Argo itself P3 Low priority type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants