Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.0.0-rc7) Argo-server deployment readiness prob httpGet uses http scheme instead of https #5425

Closed
farrajota opened this issue Mar 17, 2021 · 5 comments
Labels

Comments

@farrajota
Copy link

Summary

When testing the new v3.0.0-rc7 version, the argo-server deployment pod initialization does not complete. The pod's readiness prob times out because it is fetching from the HTTP scheme instead of HTTPS.

Fix: Edit the argo server deployment

$ kubectl -n argo edit deployments.apps argo-server

...
    spec:
      containers:
      - args:
        - server
        image: argoproj/argocli:v3.0.0-rc7
        imagePullPolicy: IfNotPresent
        name: argo-server
        ports:
        - containerPort: 2746
          name: web
          protocol: TCP
        readinessProbe:
          failureThreshold: 3
          httpGet:
            path: /
            port: 2746
            scheme: HTTPS  # <- Change this from HTTP
...

Diagnostics

What Kubernetes provider are you using?

Minikube

$ minikube version
minikube version: v1.17.1
commit: 043bdca07e54ab6e4fc0457e3064048f34133d7e

Kubectl client + server versions

$ kubectl version 
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:28:09Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.0", GitCommit:"af46c47ce925f4c4ad5cc8d1fca46c7b77d13b38", GitTreeState:"clean", BuildDate:"2020-12-08T17:51:19Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

What version of Argo Workflows are you running?

kubectl apply -n argo -f https://raw.githubusercontent.com/argoproj/argo/v3.0.0-rc7/manifests/install.yaml

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@simster7
Copy link
Member

Related #5212

@simster7
Copy link
Member

@alexec Does this warrant a new release? Can't change the manifests without moving the tag to a new commit

@simster7
Copy link
Member

#5228

@alexec
Copy link
Contributor

alexec commented Mar 17, 2021

Yes. Rc7 is unusable

@simster7
Copy link
Member

Yes. Rc7 is unusable

Starting new release

@alexec alexec closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants