Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Move shared V3 components to argo-ui #4685

Closed
alexec opened this issue Dec 9, 2020 · 2 comments
Closed

UI: Move shared V3 components to argo-ui #4685

alexec opened this issue Dec 9, 2020 · 2 comments

Comments

@alexec
Copy link
Contributor

alexec commented Dec 9, 2020

Summary

Move the shared UI component to argo-ui.

Use Cases

This will make it easier to reuse those components.

@dcherman @alexmt I think we should go over this list and make a determination:

Simple UI components (e.g. wrap a form input or add some feature to it):

ui/src/app/shared/components/button.tsx
ui/src/app/shared/components/chat-button.tsx
ui/src/app/shared/components/checkbox-list.tsx
ui/src/app/shared/components/data-loader-dropdown.tsx
ui/src/app/shared/components/drop-down-button.tsx
ui/src/app/shared/components/icon.ts
ui/src/app/shared/components/icons.ts
ui/src/app/shared/components/link-button.tsx
ui/src/app/shared/components/loading.tsx
ui/src/app/shared/components/notice.tsx
ui/src/app/shared/components/nudge.tsx
ui/src/app/shared/components/number-input.tsx
ui/src/app/shared/components/text-input.tsx
ui/src/app/shared/components/filter-drop-down.tsx
ui/src/app/shared/components/toggle-button.tsx
ui/src/app/shared/components/upload-button.tsx
ui/src/app/shared/components/tags-input/tags-input.tsx

Complex UI components:

ui/src/app/shared/components/editors/key-value-editor.tsx
ui/src/app/shared/components/editors/labels-and-annotations-editor.tsx
ui/src/app/shared/components/editors/metadata-editor.tsx
ui/src/app/shared/components/error-notice.tsx
ui/src/app/shared/components/object-editor/object-editor.tsx
ui/src/app/shared/components/object-parser.ts
ui/src/app/shared/components/resource-editor/resource-editor.tsx
ui/src/app/shared/components/zero-state.tsx

Fast SVG DAG rendering panel:

ui/src/app/shared/components/graph/coffman-graham-sorter.ts
ui/src/app/shared/components/graph/dfs-sorter.ts
ui/src/app/shared/components/graph/fast-layout.ts
ui/src/app/shared/components/graph/graph-panel.scss
ui/src/app/shared/components/graph/graph-panel.tsx
ui/src/app/shared/components/graph/icon.tsx
ui/src/app/shared/components/graph/label.tsx
ui/src/app/shared/components/graph/layout.ts
ui/src/app/shared/components/graph/pretty-layout.ts
ui/src/app/shared/components/graph/types.ts


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@alexec alexec added the type/feature Feature request label Dec 9, 2020
@alexec alexec changed the title Move UI V3 components to argo-ui Move shared UI V3 components to argo-ui Dec 9, 2020
@alexec alexec removed the type/feature Feature request label Apr 16, 2021
@stale
Copy link

stale bot commented Jun 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 16, 2021
@stale stale bot closed this as completed Jun 23, 2021
@agilgur5 agilgur5 changed the title Move shared UI V3 components to argo-ui UI: Move shared V3 components to argo-ui Sep 27, 2024
@agilgur5 agilgur5 added area/ui type/tech-debt problem/stale This has not had a response in some time labels Sep 27, 2024
@agilgur5
Copy link
Member

agilgur5 commented Sep 27, 2024

I think most of these were not moved (although a few might have been duplicated). They won't be moved these days per argoproj/argo-ui#453

@agilgur5 agilgur5 removed the problem/stale This has not had a response in some time label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants