Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Viewing Sub-Workflows in Top level Workflows #4238

Closed
DP19 opened this issue Oct 8, 2020 · 6 comments
Closed

Support Viewing Sub-Workflows in Top level Workflows #4238

DP19 opened this issue Oct 8, 2020 · 6 comments
Labels

Comments

@DP19
Copy link

DP19 commented Oct 8, 2020

Summary

Our use case in Argo depends a lot on using the Workflow of Workflows model. With this however, we are only able to see that a sub-workflow was spawned and some logs that it ran successfully. If we want to see the steps within that sub-workflow we have to back out of the top level workflow and dive into the spawned workflow.

It would be great to be able to see the full output of those sub-workflows within the top level workflow to get a better overall picture of our pipeline


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@DP19 DP19 added the type/feature Feature request label Oct 8, 2020
@jessesuen
Copy link
Member

I don't think we should show the fully embedded workflow in the workflow-of-workflows pattern, but what we can/should do is link to the other workflow when we detect that the resource kind is a Workflow.

@jessesuen
Copy link
Member

@DP19 would you like to submit a PR for the above? Would be a UI only change

@DP19
Copy link
Author

DP19 commented Oct 8, 2020

Yeah, I can give this a shot. Any ideas on what would need to be changed exactly. Not familiar with the code base yet.

@alexec
Copy link
Contributor

alexec commented Oct 8, 2020

Try this help: https://argoproj.github.io/argo/CONTRIBUTING/

@DP19
Copy link
Author

DP19 commented Oct 9, 2020

Thanks @alexec. Someone else can take this over. I just took a quick look and i'm not well versed in node. But from what i can tell just by following the workflow of workflow guide as an example, then using the apiDocs to get info about the spawned workflow, there doesn't seem to be any reference to the sub workflow that gets launched so I'm not positive this is just a UI change

@agilgur5
Copy link
Member

Closing as duplicate of #6922 as that one has more up votes (though of course this one came first)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants