Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retroactive/historical TTLStrategy and activeDeadlineSeconds #2992

Open
alexec opened this issue May 10, 2020 · 2 comments
Open

Retroactive/historical TTLStrategy and activeDeadlineSeconds #2992

alexec opened this issue May 10, 2020 · 2 comments
Labels
area/controller Controller issues, panics area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more type/feature Feature request

Comments

@alexec
Copy link
Contributor

alexec commented May 10, 2020

Summary

Currently you can set activeDeadlineSeconds and ttlStrategy on a per workflow basis, or as a default. But neither apply retroactively.

Motivation

So we can clean-up historical workflows automatically, reducing operating costs.

Proposal

For new workflows we can apply them automatically when we set-up defaults.

For historical workflows, we can't do activeDeadlineSeconds. This is applied to pods when they are created.

For historical workflows, we already have an TTL informer that will delete them. What we could do is when that informer starts, if they are missing the value, and we think they should have it, we patch them.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@alexec alexec added the type/feature Feature request label May 10, 2020
@simster7
Copy link
Member

simster7 commented May 10, 2020

activeDeadlineSeconds only applies to Running workflows... how would it be used to clean up historical workflows?

@alexec
Copy link
Contributor Author

alexec commented May 10, 2020

For historical workflows, we can't do activeDeadlineSeconds.

@alexec alexec added the area/controller Controller issues, panics label Feb 7, 2022
@agilgur5 agilgur5 added the area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more label Oct 16, 2024
@agilgur5 agilgur5 changed the title Controller workflow TTLStrategy and activeDeadlineSeconds Retroactive/historical TTLStrategy and activeDeadlineSeconds Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Controller issues, panics area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more type/feature Feature request
Projects
None yet
Development

No branches or pull requests

3 participants