Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon containers don't support retry strategy #13705

Closed
MenD32 opened this issue Oct 4, 2024 · 3 comments
Closed

daemon containers don't support retry strategy #13705

MenD32 opened this issue Oct 4, 2024 · 3 comments
Labels
area/daemon-steps area/retryStrategy Template-level retryStrategy solution/duplicate This issue or PR is a duplicate of an existing one type/feature Feature request

Comments

@MenD32
Copy link

MenD32 commented Oct 4, 2024

Summary

daemon containers should be able to retry in order to ensure the stability of the workflow

Use Cases

  • CICD unit testing pipelines - when testing features that rely on external services, I want the other services (that may be daemon containers) to be consistent
  • "Rare resource" dependent workflows - for workflows that depend on "rare resources" (such as GPUs), they might have preemptive scheduling (like spot instances), so I'd like my workflow to wait for the resource to be available again

Message from the maintainers:

Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.

@MenD32 MenD32 added the type/feature Feature request label Oct 4, 2024
@MenD32
Copy link
Author

MenD32 commented Oct 4, 2024

I'd also like to contribute to solve this issue

@agilgur5 agilgur5 added area/daemon-steps type/support User support issue - likely not a bug and removed type/feature Feature request labels Oct 4, 2024
@MenD32
Copy link
Author

MenD32 commented Oct 4, 2024

after looking at the code, i think a better fix would be to amend retry policy because of the createWorkflowPod function, which is kinda huge.

the something like retryStrategy: always

which i might add, doesn't work currently on daemon containers, from my testing

@MenD32 MenD32 changed the title create daemon containers with deployments instead of pods daemon containers don't support retry strategy Oct 15, 2024
@agilgur5 agilgur5 added type/feature Feature request solution/duplicate This issue or PR is a duplicate of an existing one area/retryStrategy Template-level retryStrategy and removed type/support User support issue - likely not a bug labels Oct 18, 2024
@agilgur5
Copy link
Member

This seems to duplicate #5833.

This also would have to handle the difference between the Controller intentionally killing it at the end vs it dying on its own

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/daemon-steps area/retryStrategy Template-level retryStrategy solution/duplicate This issue or PR is a duplicate of an existing one type/feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants